This vote is now closed. Result: 3 positive binding votes. Thanks to all participating.
On Thu, Jul 15, 2021 at 7:36 PM Alexander Saydakov < [email protected]> wrote: > +1 > > - verified gpg signature > - checked shasum > - unpacked the code - looks good as expected > - cd build > - cmake .. > - make > - make test > > > > > On Tue, Jul 13, 2021 at 10:47 AM Jon Malkin <[email protected]> wrote: > >> +1 (binding) >> >> - downloaded the zip from dist (didn't bother with github cuz that's not >> the official release object) >> - verified signature and checksum >> - building unit tests: no errors >> - ran unit tests: no errors (not even a sporadic false positive!) >> - ran python unit tests: no errors >> >> One thing I always forget is that I need to add pybind11 separately from >> the download. I don't think we want to figure out packaging that in our >> zip, but I usually just remember to do that when I get an error trying to >> run python tests. Seems suboptimal. >> >> jon >> >> On Mon, Jul 12, 2021 at 2:16 PM leerho <[email protected]> wrote: >> >>> +1 (binding) >>> - Downloaded from GitHub: 3.1.0-rc2 >>> - cmake .., make and make test all work fine, no errors. >>> - checked that 3.1.0-rc2 is loaded into >>> /dist/dev/datasketches/cpp/3.1.0-rc2 >>> - LICENSE, NOTICE OK, (remember next time to update the year to 2021) >>> >>> Lee, >>> >>> >>> >>> >>> >>> >>> On Fri, Jul 9, 2021 at 3:57 PM Alexander Saydakov >>> <[email protected]> wrote: >>> >>>> Hello Apache DataSketches PMC and Community, >>>> >>>> >>>> This is a call for vote to release Apache DataSketches-cpp candidate >>>> version: 3.1.0-rc2 >>>> >>>> >>>> Changes since rc1: >>>> >>>> - fixed a compilation issue with some older compilers such as gcc >>>> 4.8.5 >>>> >>>> >>>> Changes since the last release 3.0.0: >>>> >>>> - Kolmogorov-Smirnov test for KLL sketch >>>> >>>> - custom seed support in Theta Jaccard similarity >>>> >>>> - Theta union bug fix >>>> >>>> - added get_max_serialized_size_bytes method for KLL and CPC >>>> sketches >>>> >>>> - added wrapped_compact_theta_sketch to avoid some cost of >>>> deserialization >>>> >>>> - massive code cleanup to avoid compiler warnings >>>> >>>> - iterator fix in KLL sketch >>>> >>>> - iterator fix in REQ sketch >>>> >>>> - exception safety fix in theta_update_sketch_base >>>> >>>> - misaligned access fix in MurmurHash3 >>>> >>>> >>>> Source repository: >>>> >>>> - https://github.com/apache/datasketches-cpp >>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=gRWKairrtuAvgT7nVnbJXv53NXbLuOW56sG46Zdy-Z4&s=q0plHqHqLPMivHLSvYhHzov95VZWUBQLXn-IWbn4ojg&e=> >>>> >>>> >>>> Git Tag for this release: >>>> >>>> - https://github.com/apache/datasketches-cpp/tree/3.1.0-rc2 >>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp_tree_3.1.0-2Drc2&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=gRWKairrtuAvgT7nVnbJXv53NXbLuOW56sG46Zdy-Z4&s=l-MWWmE2GmudVF8ngb22lnSGdHqEbqrYgYBWYh3Lfxg&e=> >>>> on >>>> branch 3.1.x >>>> >>>> >>>> Git HashId for this release is: >>>> a375f9805ab8064b20e6a1b82282e4d04b102328 >>>> >>>> >>>> The Release Candidate / Zip Repository: >>>> >>>> - >>>> https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.1.0-rc2/ >>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_cpp_3.1.0-2Drc2_&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=gRWKairrtuAvgT7nVnbJXv53NXbLuOW56sG46Zdy-Z4&s=6a1Mte0nTU_LbfpyJnSTQFGI3XD4B_cA8hdGXbTX6AQ&e=> >>>> >>>> >>>> The public signing key can be found in the KEYS file: >>>> >>>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_KEYS&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=gRWKairrtuAvgT7nVnbJXv53NXbLuOW56sG46Zdy-Z4&s=4C5rtrhyyeL5KLFI3nB6EI2trL652rnNbZ4wUt92ESY&e=> >>>> >>>> >>>> >>>> The artifacts have been signed with key: >>>> >>>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < >>>> [email protected]> >>>> >>>> >>>> Build & Test Guide: >>>> >>>> - >>>> https://github.com/apache/datasketches-cpp/blob/3.1.0-rc2/README.md >>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp_blob_3.1.0-2Drc2_README.md&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=gRWKairrtuAvgT7nVnbJXv53NXbLuOW56sG46Zdy-Z4&s=jCX_Ft9cyGzbKmgSybInPBUlGXDzDy5E8B0X_YNsnwc&e=> >>>> >>>> >>>> The vote will be performed as follows: >>>> >>>> - This letter will be published on dev@ and remain open for at >>>> least 72 hours (excluding weekends and holidays), AND until at least 3 (+1) >>>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the >>>> community can vote. >>>> >>>> >>>> Please vote accordingly: >>>> >>>> >>>> [ ] +1 approve >>>> >>>> [ ] +0 no opinion >>>> >>>> [ ] -1 disapprove with the reason >>>> >>>> >>>> Thanks, >>>> >>>> Alexander Saydakov >>>> >>>> [email protected] >>>> >>>> >>>>
