+1 - LICENSE and NOTICE look fine - checked shasum - verified GPG signature - make, make install - "create extension datasketches" in a test DB, run some test queries
On Mon, Aug 2, 2021 at 12:13 PM leerho <[email protected]> wrote: > +1 (binding) > > I checked: > - make > - sudo make install > - createdb test > - psql test > - *test=# *create extension datasketches; > - *test=#* select cpc_sketch_to_string(cpc_sketch_build(1)); # > Successful printout > - *test=#* ^Z > > > On Fri, Jul 30, 2021 at 4:04 PM Jon Malkin <[email protected]> wrote: > >> +1 (binding) >> >> I checked: >> - LICENSE and NOTICE present >> - verified shasum and gpg signature >> - make && sudo make install >> - ran several example tests from README.md >> >> jon >> >> >> On Thu, Jul 22, 2021 at 7:47 PM Alexander Saydakov >> <[email protected]> wrote: >> >>> Dear Apache DataSketches PMC and Community, >>> >>> >>> This is a call for a vote to release >>> Apache DataSketches-postgresql version 1.5.0-rc2 >>> >>> >>> This is an extension for PostgreSQL database based on the >>> Apache DataSketches-cpp core library. >>> >>> >>> Change since rc1: >>> >>> >>> - updated META.json >>> >>> Changes in this release since 1.4.0: >>> >>> - Based on the latest datasketches-cpp 3.1.0 >>> - Fixed bug in Theta union (in core 3.1.0) >>> - Used new wrapped_compact_theta_sketch to avoid some cost of >>> deserialization >>> - Fixed handling of default parameters >>> >>> Source repository: https://github.com/apache/datasketches-postgresql >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dpostgresql&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=7i7V3z3rZFTzdtfJ9yV7q7YgUcU8z0GRO5hvmb-xvyI&s=IMRutkCP_6EMLJhi8n2LePfZpmpYDouLJFcw5BGeLP8&e=> >>> >>> >>> Git tag for this release candidate: >>> https://github.com/apache/datasketches-postgresql/tree/1.5.0-rc2 >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dpostgresql_tree_1.5.0-2Drc2&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=7i7V3z3rZFTzdtfJ9yV7q7YgUcU8z0GRO5hvmb-xvyI&s=6Isaorf75DLwEzJf-hcp7qmdISEkkJmG3cxuYAZ-iD0&e=> >>> >>> >>> The release candidate repository: >>> https://dist.apache.org/repos/dist/dev/datasketches/postgresql/1.5.0-rc2 >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_postgresql_1.5.0-2Drc2&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=7i7V3z3rZFTzdtfJ9yV7q7YgUcU8z0GRO5hvmb-xvyI&s=-ik23xlO99hXiLKThj5-azQfIDyh5_OxA4BUE-EGhAE&e=> >>> >>> >>> How to build and install: >>> https://github.com/apache/datasketches-postgresql/blob/1.5.0-rc2/README.md >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dpostgresql_blob_1.5.0-2Drc2_README.md&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=7i7V3z3rZFTzdtfJ9yV7q7YgUcU8z0GRO5hvmb-xvyI&s=vBpgBIhATHJZIZIzGFkbTfjR-x_orGzPWnuOsLbyVpw&e=> >>> >>> >>> This vote will remain open for at least 72 hours and at least 3 (+1) >>> PMC votes or a majority of (+1) are acquired. >>> >>> >>> Please vote accordingly: >>> >>> >>> [ ] +1 approve >>> >>> [ ] +0 no opinion >>> >>> [ ] -1 disapprove with the reason >>> >>> >>> Thank you. >>> >>> Alexander Saydakov >>> >>> [email protected] >>> >>> >>>
