+1 from me I checked: - gpg signature - shasum - mvn test - mvn package - mvn install
I'd followed the instructions to install the toolchain when doing RC1, and those were clear enough at the time. It successfully tested the multiple versions of Java as a result. jon On Fri, Sep 10, 2021 at 6:44 PM Alexander Saydakov <[email protected]> wrote: > +1 > > - gpg signature OK > - shasum OK > - mvn test OK > > > On Thu, Sep 9, 2021 at 9:09 PM leerho <[email protected]> wrote: > >> +1 (binding) >> >> - The zip, asc and sha512 files are properly installed in >> *dist/dev/datasketches/memory/2.0.0-RC2* >> - The files uploaded to Nexus are copied to >> *dist/dev/datasketches/memory/2.0.0-RC2/maven* >> - Visually checked LICENSE, NOTICE files, dates are OK >> - Validated .asc and .sha512 signatures >> - ran *mvn clean install *successfully ran tests and generated the >> proper jars in .m2 >> This ran tests using JDK 8, 9 and 11 on my system. >> - Maven automatically ran the RAT plugin and found no files with >> missing license headers. >> >> *Eclipse Hint #1: *As a hint to other developers that may be trying >> this: I had difficulty at first getting Eclipse to properly import the >> unzipped multi-module project. Because I already had an earlier version of >> this project already part of Eclipse it complained about duplicate project >> names. The solution is to do this: >> >> - In Project Explorer, right-click: select Import/Existing Maven >> Projects >> - Fill in the Root Directory >> - Under *Advanced* select *Name template*, select >> *[artifactid]-[version]* then append "-rc2" >> - Make sure all the projects and the pom are selected in the main >> window >> - click *Finish* >> >> *Eclipse Hint #2: *Due to a bug in Eclipse (which will initially show up >> as unresolved access errors), read the *README* and also the *Eclipse >> IDE Setup, *which you can find at the end of the README. The section >> "Setting compiler arguments for JPMS" explains how to get around the >> Eclipse bug. >> >> Cheers, >> Lee. >> >> On Thu, Sep 9, 2021 at 4:26 PM David Cromberge <[email protected]> >> wrote: >> >>> ### Add support for Java 9 through 13 (inclusive), whilst retaining >>> support >>> for Java 8. >>> ### Add modularity support via Java Platform Module System for Java9+. >>> ### Add support for user to provide memory request server implementation >>> for different resource types. >>> ### Significant refactoring to better encapsulate internals and simplify >>> public facing API. >>> ### Add documentation to explain project structure and configuration for >>> popular IDEs including Eclipse and IntelliJ. >>> >>> In response to helpful feedback received for the previous release >>> candidate (RC1), we have additionally: >>> >>> ### Made further improvements to documentation and usage instructions. >>> ### Provided a script to build and package the library for a single Java >>> version. >>> >>> Hello Apache DataSketches PMC and Community, >>> >>> 1. This is a call for vote to release Apache DataSketches-memory >>> candidate >>> version: 2.0.0-RC2 >>> >>> NOTE 1: This component of the DataSketches library provides >>> high-performance access to off-heap memory for Java applications. These >>> are >>> low-level functions that are used by other DataSketches components. It >>> does >>> not provide any command-line interface or GUI. >>> >>> 2. Source repository: >>> - https://github.com/apache/datasketches-memory >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dmemory&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=FU8O3CX0smtb7thVHSj-qTL3F07bA4cH3PlaJd1TSH8&s=Rscyg-yInsuSMRRXydZxu1MJ-CKBz8dABEfhP7BEC_E&e=> >>> >>> Git Tag for this release: >>> - https://github.com/apache/datasketches-memory/tree/2.0.0-RC2 >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dmemory_tree_2.0.0-2DRC2&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=FU8O3CX0smtb7thVHSj-qTL3F07bA4cH3PlaJd1TSH8&s=xRA14ajXk8WZq9FIb9254dsDUV0wHEXmr63r1-fng3E&e=> >>> on >>> branch 2.0.X >>> >>> Git HashId for this release starts with: f2128e3 >>> >>> 3. The Release Candidate / Zip Repository: >>> - >>> https://dist.apache.org/repos/dist/dev/datasketches/memory/2.0.0-RC2/ >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_memory_2.0.0-2DRC2_&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=FU8O3CX0smtb7thVHSj-qTL3F07bA4cH3PlaJd1TSH8&s=NyhETDVP2LTaWncRkdJtRRz1vdoqO74c4ZmRavYSeZ0&e=> >>> >>> The public signing key can be found in the KEYS file: >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_KEYS&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=FU8O3CX0smtb7thVHSj-qTL3F07bA4cH3PlaJd1TSH8&s=hkOLUvP2doSMVpyiA5ZL-MEazICvqqigx2a4j18OegI&e=> >>> >>> The artifacts have been signed with --keyid-format SHORT : A21C4E36 >>> >>> 4. Repository: Maven Central [Nexus](http://repository.apache.org >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__repository.apache.org&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=FU8O3CX0smtb7thVHSj-qTL3F07bA4cH3PlaJd1TSH8&s=DC6IqNtX6YnA7nHkXwkzUuTfMRoeHISOKZp7PUeswfk&e=>) >>> (Jar >>> Artifacts): >>> - >>> >>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-memory/2.0.0/ >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_groups_staging_org_apache_datasketches_datasketches-2Dmemory_2.0.0_&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=FU8O3CX0smtb7thVHSj-qTL3F07bA4cH3PlaJd1TSH8&s=jcAkhOgE6mP5eG8DhATKz64miOwFfi6MjrGRKMrdPlw&e=> >>> >>> 5. Build & Test Guide: >>> - >>> https://github.com/apache/datasketches-memory/blob/2.0.0-RC2/README.md >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dmemory_blob_2.0.0-2DRC2_README.md&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=FU8O3CX0smtb7thVHSj-qTL3F07bA4cH3PlaJd1TSH8&s=Z6rguWXvepnXz7_USGOe_2_NoLVqZV7B6RsJWJTkvZ4&e=> >>> >>> 6. The vote will be performed as follows: >>> - This letter will be published on dev@ and remain open for at least >>> 72 >>> hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >>> votes or a majority of (+1) PMC votes are acquired. Anyone in the >>> community >>> can vote. >>> >>> Please vote accordingly: >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> Thanks, >>> David Cromberge >>> [email protected] >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>>
