Note: the 72 hour window expires on Friday at 4:36 PM PDT if we have sufficient votes. Since David is on vacation, and, hopefully, if we have sufficient votes I can complete the release on Friday. Otherwise, someone else will have to finish the release.
On Wed, Sep 29, 2021 at 8:54 AM leerho <[email protected]> wrote: > +1 (binding) > - Checked LICENSE, NOTICE > - test from Eclipse > - mvn clean test > - ran CI workflow on 3.0.X branch -RC2 (runs JDK matrix) > > Note to Alex's question: MurmurHash3v2 was not being used internally and > it was moved to Memory because it was the only class in ds-java that called > JVM internals (Unsafe). This way, all of our code that uses JVM internals > is contained in Memory. This simplifies our plan for the next phase > migration to Panama. The tests for MurmurHash3v2 was also moved to Memory, > but I forgot to remove it from ds-java. So in this case the testing is > redundant. We will remove this test from ds-java after release. > > On Wed, Sep 29, 2021 at 2:45 AM David Cromberge <[email protected]> > wrote: > >> I noticed that there were additional test cases in that suite that were >> testing other hash-related methods within the Datasketches-library so I >> assumed this was intentionally left in place. >> To your point, I think we should probably rename or consolidate it in >> master after the release. >> >> On 2021/09/29 02:25:18, Alexander Saydakov <[email protected]> >> wrote: >> > Is it intentional that MurmurHash3v2.java was moved, but a corresponding >> > test is still in this repo? >> > >> > On Tue, Sep 28, 2021 at 7:13 PM Alexander Saydakov < >> [email protected]> >> > wrote: >> > >> > > +1 >> > > >> > > - verified gpg signature >> > > - checked shasum >> > > - mvn test (openjdk 8) >> > > >> > > On Tue, Sep 28, 2021 at 4:36 PM David Cromberge < >> [email protected]> >> > > wrote: >> > > >> > >> ### Update dependency on Datasketches-memory to 2.0.0 enabling full >> support for reading from and writing sketches to off-heap memory in JDKs >> 8-13. >> > >> >> > >> ### MurmurHash3v2.java was moved out of Datasketches-java to >> Datasketches-memory, and most deprecated API methods from 2.0.0 are now >> also removed. >> > >> >> > >> ### Finally, the MemoryRequestServer changes and improvements from >> Datasketches-memory have been integrated into the Datasketches-java API. >> > >> >> > >> >> > >> Hello Apache DataSketches PMC and Community, >> > >> >> > >> 1. This is a call for vote to release Apache DataSketches-java >> candidate >> > >> version: 3.0.0-RC2 >> > >> >> > >> NOTE 1: This is the core Java component of the DataSketches >> library >> > >> that includes all the sketch algorithms in production-ready >> packages. These >> > >> sketches can be called directly from this component or used in >> conjunction >> > >> with the adaptor components such as Apache Pig, Apache Hive, or the >> > >> aggregator adaptors built into Apache Druid. >> > >> >> > >> 2. Source repository: >> > >> - https://github.com/apache/datasketches-java < >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Djava&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=a7E5v4JfN1jXd62M6xCtRfzaMxoVInUUSDReYM-xoh0&s=mkPCdo3WqnN7Lh5a8zLG5bzevHBeXsf7C0e7zOtQY6M&e= >> > >> > >> >> > >> Git Tag for this release: >> > >> - https://github.com/apache/datasketches-java/tree/3.0.0-RC2 < >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Djava_tree_3.0.0-2DRC2&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=a7E5v4JfN1jXd62M6xCtRfzaMxoVInUUSDReYM-xoh0&s=XM6JE31YyyA8Qqsi2urvJzxd1lO0EZSYzj63yKVTWSk&e=> >> on branch >> > >> 3.0.X >> > >> >> > >> Git HashId for this release starts with: 522c3667 >> > >> >> > >> 3. The Release Candidate / Zip Repository: >> > >> - >> https://dist.apache.org/repos/dist/dev/datasketches/java/3.0.0-RC2/ < >> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_java_3.0.0-2DRC2_&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=a7E5v4JfN1jXd62M6xCtRfzaMxoVInUUSDReYM-xoh0&s=JXW9o9yNKibUIan0gtzBj_nK-dHDqRySFmgoRNxz_8o&e= >> > >> > >> >> > >> The public signing key can be found in the KEYS file: >> > >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS < >> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_KEYS&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=a7E5v4JfN1jXd62M6xCtRfzaMxoVInUUSDReYM-xoh0&s=8rDnEFhI7k9yIr73BwroRnjBodh96Jwdl4S_waQeIx0&e= >> > >> > >> >> > >> The artifacts have been signed with --keyid-format SHORT : >> A21C4E36 >> > >> >> > >> 4. Repository: Maven Central [Nexus](http://repository.apache.org < >> https://urldefense.proofpoint.com/v2/url?u=http-3A__repository.apache.org&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=a7E5v4JfN1jXd62M6xCtRfzaMxoVInUUSDReYM-xoh0&s=_RQXtC6U6_M2nU_eJfRoDessKUFwaQt3eSDqG7Y4KSg&e=>) >> (Jar >> > >> Artifacts): >> > >> - >> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/3.0.0/ >> < >> https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_groups_staging_org_apache_datasketches_datasketches-2Djava_3.0.0_&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=a7E5v4JfN1jXd62M6xCtRfzaMxoVInUUSDReYM-xoh0&s=8Sja6eoRiNHrwlnCVnA-_ssj9rEcaCas_gEnlGsVVTU&e= >> > >> > >> >> > >> 5. Build & Test Guide: >> > >> - >> https://github.com/apache/datasketches-java/blob/3.0.0-RC2/README.md < >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Djava_blob_3.0.0-2DRC2_README.md&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=a7E5v4JfN1jXd62M6xCtRfzaMxoVInUUSDReYM-xoh0&s=qKMwyTbHX1Ouh-xClFB9bf-7BefslV7BNjZdPi7R9mo&e= >> > >> > >> >> > >> 6. The vote will be performed as follows: >> > >> - This letter will be published on dev@ and remain open for at >> least 72 >> > >> hours (excluding weekends and holidays), AND until at least 3 (+1) >> PMC >> > >> votes or a majority of (+1) PMC votes are acquired. Anyone in the >> community >> > >> can vote. >> > >> >> > >> Please vote accordingly: >> > >> >> > >> [ ] +1 approve >> > >> [ ] +0 no opinion >> > >> [ ] -1 disapprove with the reason >> > >> >> > >> Thanks, >> > >> David Cromberge >> > >> >> > >> [email protected] >> > >> >> > >> >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
