leerho commented on a change in pull request #106:
URL:
https://github.com/apache/datasketches-website/pull/106#discussion_r741565533
##########
File path: docs/Theta/ThetaSetOpsCornerCases.md
##########
@@ -85,7 +85,7 @@ The octal digit `ID = ((theta == 1.0) ? 4 : 0) |
((retainedEntries > 0) ? 2 : 0)
| Shorthand Notation | theta | retained entries | empty |
Has Seen Data | ID | Comments |
|:---------------------------------:|:-----:|:----------------:|:----------:|:-------------:|:--:|:------------------------------:|
| New {1.0,0,T} | 1.0 | 0 | T |
F | 5 | New Sketch, p=1.0 (default) |
-| Exact {1.0,>0,F} | 1.0 | >0 | F |
T | 6 | Exact Mode |
+| Exact {1.0,>0,F} | 1.0 | >0 | F |
T | 7 | Exact Mode |
| Estimation {<1.0,>0,F} | <1.0 | >0 | F |
T | 2 | Estimation Mode |
Review comment:
This is not correct. 6 is the correct value, not 7. Look at lines
79-81 of the raw text file.
The other typo fix in line 179 is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
