leerho commented on a change in pull request #107:
URL:
https://github.com/apache/datasketches-website/pull/107#discussion_r753730785
##########
File path: docs/Theta/ThetaSetOpsCornerCases.md
##########
@@ -82,60 +79,38 @@ We can assign a single octal digit ID to each state where
The octal digit `ID = ((theta == 1.0) ? 4 : 0) | ((retainedEntries > 0) ? 2 :
0) | (empty ? 1 : 0);`
-| Shorthand Notation | theta | retained entries | empty |
Has Seen Data | ID | Comments |
-|:---------------------------------:|:-----:|:----------------:|:----------:|:-------------:|:--:|:------------------------------:|
-| New {1.0,0,T} | 1.0 | 0 | T |
F | 5 | New Sketch, p=1.0 (default) |
-| Exact {1.0,>0,F} | 1.0 | >0 | F |
T | 6 | Exact Mode |
-| Estimation {<1.0,>0,F} | <1.0 | >0 | F |
T | 2 | Estimation Mode |
-| NewDegen {<1.0,0,T}<sup>2</sup> | <1.0 | 0 | T |
F | 1 | New Sketch, user sets p<1.0 |
-| ResultDegen {<1.0,0,F}<sup>3</sup>| <1.0 | 0 | F |
T | 0 | Valid Intersect or AnotB result |
+| Shorthand Notation | theta | retained entries | empty |
Has Seen Data | ID | Comments |
+|:---------------------------------:|:-----:|:----------------:|:----------:|:-------------:|:--:|:-------------------------------:|
+| Empty {1.0,0,T} | 1.0 | 0 | T |
F | 5 | Empty Sketch |
+| Exact {1.0,>0,F} | 1.0 | >0 | F |
T | 6 | Exact Mode |
+| Estimation {<1.0,>0,F} | <1.0 | >0 | F |
T | 2 | Estimation Mode |
+| Degenerate {<1.0,0,F}<sup>3</sup> | <1.0 | 0 | F |
T | 0 | Valid Intersect or AnotB result |
---
-<sup>2</sup> *New Degenerate*: New Empty Sketch where the user sets *p < 1.0*.
This can be safely reinterpreted as {1.0,0,T} because it has not seen any
data.<br>
-<sup>3</sup> *Result Degenerate*: Can appear as a result of a an Intersection
or AnotB of certain combination of sketches.
-
-## Invalid States of a Sketch
-The remaining three combinations of the variables represent internal errors
and should not occur.
Review comment:
Why did you remove the clarification of the invalid states of the
sketch? This is important because the average reader will immediately know
that 3 boolean values yield 8 possible combinations and wonder why don't we
discuss those corner cases! Just because it is obvious to you doesn't mean it
will be obvious to the reader why we can ignore the other 4 cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
