Because of this small mistake in Readme, please consider this vote canceled. I will prepare RC2 shortly. Thank you.
On Thu, Dec 16, 2021 at 10:57 PM Alexander Saydakov <[email protected]> wrote: > Oh, you actually follow the new instructions. I have never tried these > build steps myself. > I believe that an actual build step is missing after the first command, > which generates makefiles, and the second command, which runs the test > binaries. > It must be: > cmake --build build/Release > > > On Thu, Dec 16, 2021 at 10:00 PM leerho <[email protected]> wrote: > >> I get exactly the same error. :( >> >> Lee. >> >> On Thu, Dec 16, 2021 at 9:53 PM leerho <[email protected]> wrote: >> >>> I cloned the code from the git release tag. Let me try the zip. >>> >>> >>> On Thu, Dec 16, 2021 at 9:46 PM leerho <[email protected]> wrote: >>> >>>> Alex, >>>> I got the first cmake command to work, but the second failed with: >>>> >>>> Unable to find executable: >>>> /Users/lrhodes/dev/git/Apache/datasketches-cpp-test/build/Release/req/test/req_test >>>> >>>> 9/9 Test #9: req_test .........................***Not Run 0.00 sec >>>> >>>> >>>> 0% tests passed, 9 tests failed out of 9 >>>> >>>> >>>> Total Test time (real) = 0.01 sec >>>> >>>> >>>> The following tests FAILED: >>>> >>>> 1 - integration_test (Not Run) >>>> >>>> 2 - hll_test (Not Run) >>>> >>>> 3 - cpc_test (Not Run) >>>> >>>> 4 - kll_test (Not Run) >>>> >>>> 5 - fi_test (Not Run) >>>> >>>> 6 - theta_test (Not Run) >>>> >>>> 7 - sampling_test (Not Run) >>>> >>>> 8 - tuple_test (Not Run) >>>> >>>> 9 - req_test (Not Run) >>>> >>>> Errors while running CTest >>>> >>>> make: *** [test] Error 8 >>>> >>>> >>>> And I checked the folder *build/Release/req/test/* and req_test is >>>> missing. >>>> Suggestions? >>>> >>>> >>>> Lee. >>>> >>>> On Wed, Dec 15, 2021 at 3:25 PM Alexander Saydakov >>>> <[email protected]> wrote: >>>> >>>>> Hello Apache DataSketches PMC and Community, >>>>> >>>>> >>>>> This is a call for vote to release Apache DataSketches-cpp candidate >>>>> version: 3.3.0-rc1 >>>>> >>>>> >>>>> Changes since datasketches-cpp 3.2.0 release on Sep 29 2021 >>>>> >>>>> - several fixes with respect to allocations using a provided >>>>> allocator instance >>>>> - fixes and improvements in cmake files for including DataSketches as >>>>> dependency in other projects >>>>> - Tuple sketch serial version 3 for compatibility with Java >>>>> - support for older serialization versions of Theta sketch >>>>> - added reset() method in Theta and Tuple sketch and union >>>>> - minor changes to some corner cases of Theta and Tuple intersection >>>>> and a-not-b operations >>>>> >>>>> Source repository: >>>>> >>>>> - https://github.com/apache/datasketches-cpp >>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=k5tPGr-i7mJ1d-v4H_detjNVYbuZvk8359upszJ_E1L_G7Vh4lDFiFCDcbuDQ-2E&s=Pakr-cv0I-5pm7cueH5bHXivsshC6gn4Yk1vRSUQjhI&e=> >>>>> >>>>> >>>>> Git Tag for this release: >>>>> >>>>> - https://github.com/apache/datasketches-cpp/tree/3.3.0-rc1 >>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp_tree_3.3.0-2Drc1&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=k5tPGr-i7mJ1d-v4H_detjNVYbuZvk8359upszJ_E1L_G7Vh4lDFiFCDcbuDQ-2E&s=ipB_klX8NHKfQC4Jsiaw397kPyra8Y9msgaXlyL-91Y&e=> >>>>> on >>>>> branch 3.1.x >>>>> >>>>> >>>>> Git HashId for this release is: >>>>> 22e0e0c10a1282d8e3f02c21f8fa2a8694115913 >>>>> >>>>> >>>>> The Release Candidate / Zip Repository: >>>>> >>>>> - >>>>> https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.3.0-rc1/ >>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_cpp_3.3.0-2Drc1_&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=k5tPGr-i7mJ1d-v4H_detjNVYbuZvk8359upszJ_E1L_G7Vh4lDFiFCDcbuDQ-2E&s=uV1YKq6Dh2oWJ9OPwjqj_4DzyyuofJ7qzJvz11Xl4Jg&e=> >>>>> >>>>> >>>>> The public signing key can be found in the KEYS file: >>>>> >>>>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_KEYS&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=k5tPGr-i7mJ1d-v4H_detjNVYbuZvk8359upszJ_E1L_G7Vh4lDFiFCDcbuDQ-2E&s=fa8tzHrQXIudENtbToxg0gowuU9T6O0ZBI2eBddJVHk&e=> >>>>> >>>>> >>>>> >>>>> The artifacts have been signed with key: >>>>> >>>>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) >>>>> <[email protected]> >>>>> >>>>> >>>>> Build & Test Guide: >>>>> >>>>> - >>>>> https://github.com/apache/datasketches-cpp/blob/3.3.0-rc1/README.md >>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Dcpp_blob_3.3.0-2Drc1_README.md&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=k5tPGr-i7mJ1d-v4H_detjNVYbuZvk8359upszJ_E1L_G7Vh4lDFiFCDcbuDQ-2E&s=n5N2beRkvJ_U3DmreIW9ln3qqH296NPEU2XLo9RnCmc&e=> >>>>> >>>>> >>>>> The vote will be performed as follows: >>>>> >>>>> - This letter will be published on dev@ and remain open for at >>>>> least 72 hours (excluding weekends and holidays), AND until at least 3 >>>>> (+1) >>>>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the >>>>> community can vote. >>>>> >>>>> >>>>> Please vote accordingly: >>>>> >>>>> >>>>> [ ] +1 approve >>>>> >>>>> [ ] +0 no opinion >>>>> >>>>> [ ] -1 disapprove with the reason >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> Alexander Saydakov >>>>> >>>>> [email protected] >>>>> >>>>
