+1 checked: - signature - checksum - mvn test (with and without strict) -- command-line only
I tried checking the maven subdir, and the signatures match but the format of the checksum files doesn't lend itself to automated testing. The command-line tool output is formatted as "<value> <filename>" but the files in the directory are just the checksum. So I only tested one of those, but it did at least give the expected EOF. jon On Mon, Jan 24, 2022 at 3:15 PM Alexander Saydakov <[email protected]> wrote: > +1 > > Checked: > - checksum > - signature > - mvn test > - datasketches-pig with this release candidate (mvn test) > - datasketches-hive with this release candidate (mvn test) > > > On Mon, Jan 24, 2022 at 1:08 PM David Cromberge <[email protected]> > wrote: > >> Hi, >> >> +1 from me, all looks good! >> >> - Rat checks passed >> - Checked SHA512 and ASC signatures >> - Verified LICENCE, README and NOTICE files are present with correct >> dates and file links >> - Verified that the maven directory is present in the release dist >> - Tests pass using mvn clean test in Java 11, and strict mode (-P) in >> Java8. >> - Tested build and unit test run in Eclipse 2021-6 and IntelliJ IDEA >> 2021.2 >> >> Thanks, >> David >> >> On 2022/01/21 19:19:03 leerho wrote: >> > # HIGHLIGHTS: This is primarily a maintenance release: >> > ### Fixed "Mikhail's Issue #368". This was a specific Theta >> set-operation >> > corner case bug. >> > ### Developed a standard model for all Theta, Tuple set operation corner >> > cases. Implemented across all corner cases for Java (and C++). >> > ### Improvements in clarity of Javadocs, primarily in Theta, Tuple >> sketches. >> > ### Fixed some parameter leakage cases related to LGTM warnings. >> > ### Improved variable naming to enhance code clarity. >> > ### Fixed warnings discovered by latest SpotBugs. >> > ### Significant improvements and cleanup of ArrayOfDoubles Tuple Sketch >> > code. >> > >> > >> > Hello Apache DataSketches PMC and Community, >> > >> > 1. This is a call for vote to release Apache DataSketches-java candidate >> > version: 3.1.0-RC1 >> > >> > NOTE 1: This is the core Java component of the DataSketches library >> > that includes all the sketch algorithms in production-ready packages. >> These >> > sketches can be called directly from this component or used in >> conjunction >> > with the adaptor components such as Hadoop Pig, Hadoop Hive, or the >> > aggregator adaptors built into Apache Druid. >> > >> > 2. Source repository: >> > - >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Djava&d=DwIFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=y1DQtDu76f8iavdeFKWEjj1jeJuYpLHWbNQidGY0034ouHvRIYESeulwxjp7MeUo&s=nUZakK_jcUMOUip0Vz5Yk9md4dG40zubRThINKgi7VY&e= >> > >> > Git Tag for this release: >> > - >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Djava_tree_3.1.0-2DRC1&d=DwIFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=y1DQtDu76f8iavdeFKWEjj1jeJuYpLHWbNQidGY0034ouHvRIYESeulwxjp7MeUo&s=dSY_qwBJasjc73v-KUurderTgb_HZmgLX_8c1HERtgo&e= >> on branch >> > 3.1.X >> > >> > Git HashId for this release starts with: 6a2254e >> > >> > 3. The Release Candidate / Zip Repository: >> > - >> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_java_3.1.0-2DRC1_&d=DwIFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=y1DQtDu76f8iavdeFKWEjj1jeJuYpLHWbNQidGY0034ouHvRIYESeulwxjp7MeUo&s=TWhRt78hY0mHDV2AV5NFjuy3oVdZsKqSlqEHf9xJsZ8&e= >> > >> > The public signing key can be found in the KEYS file: >> > - >> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_datasketches_KEYS&d=DwIFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=y1DQtDu76f8iavdeFKWEjj1jeJuYpLHWbNQidGY0034ouHvRIYESeulwxjp7MeUo&s=YARq-LZ0k83DvGtHxrAucXyWGRxsqPFuENzGxsKqXHU&e= >> > >> > The artifacts have been signed with --keyid-format SHORT : 8CD4A902 >> > >> > 4. Repository: Maven Central [Nexus]( >> https://urldefense.proofpoint.com/v2/url?u=http-3A__repository.apache.org&d=DwIFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=y1DQtDu76f8iavdeFKWEjj1jeJuYpLHWbNQidGY0034ouHvRIYESeulwxjp7MeUo&s=ynLFWo1C52rQlw3FiTkYUM41j3nxdU5NYUBj-UI55z4&e= >> ) (Jar >> > Artifacts): >> > - >> > >> https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_groups_staging_org_apache_datasketches_datasketches-2Djava_3.1.0_&d=DwIFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=y1DQtDu76f8iavdeFKWEjj1jeJuYpLHWbNQidGY0034ouHvRIYESeulwxjp7MeUo&s=ZW01nG-6tOI6DVNFrdrAODv1R6Yit7TWYAAXcujUY0Y&e= >> > >> > 5. Build & Test Guide: >> > - >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_datasketches-2Djava_blob_3.1.0-2DRC1_README.md&d=DwIFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5XKs67PBsM9PIITdUxN3HPigYyrsCBiUuPRPWJgzNuE&m=y1DQtDu76f8iavdeFKWEjj1jeJuYpLHWbNQidGY0034ouHvRIYESeulwxjp7MeUo&s=a_dHTM1N-JWYXxq4aUAPosaExk7oHlVc9xvffMidMAk&e= >> > >> > 6. The vote will be performed as follows: >> > - This letter will be published on dev@ and remain open for at >> least 72 >> > hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >> > votes or a majority of (+1) PMC votes are acquired. Anyone in the >> community >> > can vote. >> > >> > Please vote accordingly: >> > >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove with the reason >> > >> > Thanks, >> > Lee Rhodes >> > [email protected] >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
