+1 from me - verified GPG signature - checked SHA checksum - cmake, make, make test - pypi packages present
I had a bit of trouble installing locally. Running: $ cmake --build build/Release -t install Resulted in the following error (output is truncated) -- Up-to-date: /tmp/install/DataSketches/include/DataSketches/kll_sketch.hpp -- Up-to-date: /tmp/install/DataSketches/include/DataSketches/kll_sketch_impl.hpp -- Up-to-date: /tmp/install/DataSketches/include/DataSketches/kll_helper.hpp -- Up-to-date: /tmp/install/DataSketches/include/DataSketches/kll_helper_impl.hpp CMake Error at kll/cmake_install.cmake:46 (file): file INSTALL cannot find "/Users/davidcr/Downloads/apache-datasketches-cpp-3.4.0-src/kll/include/kolmogorov_smirnov.hpp": No such file or directory. Call Stack (most recent call first): cmake_install.cmake:57 (include) I followed the steps in the README directly, as I said this could be user error. David On 2022/05/13 00:52:41 leerho wrote: > +1 > - verified GPG signature > - checked SHA checksum > - cmake, make, make test > > > On Wed, May 11, 2022 at 4:05 PM Alexander Saydakov > <[email protected]> wrote: > > > +1 > > > > - verified GPG signature > > - checked SHA checksum > > - cmake, make, make test > > - built datasketches-postgresql based on this release candidate > > > > > > On Wed, May 11, 2022 at 12:06 AM Jon Malkin <[email protected]> wrote: > > > >> Hello Apache DataSketches PMC and Community, > >> > >> > >> This is a call for vote to release Apache DataSketches-cpp candidate > >> version: 3.4.0-rc1 > >> > >> > >> Changes since datasketches-cpp 3.3.0 release > >> - addition of Quantiles sketch: the algorithm is largely obsolete vs KLL > >> but this provides compatibility for existing sketches > >> - support for serde instances in all relevant sketches; class-level > >> templates are now marked deprecated > >> - greater API consistency across quantiles, KLL, and REQ, including new > >> get_sorted_view() interface, inclusive mode > >> > >> - cmake minimum version bump to 3.16 > >> > >> - Kolmogorov-Smirnov test for KLL and classic Quantiles available in > >> python > >> > >> - code cleanup and bugfixes > >> > >> > >> Source repository: > >> > >> - https://github.com/apache/datasketches-cpp > >> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!C4Gc0OPbIRXeM6CqcrwntImseB8V3gH4SKgxD7vGd2viTuyC1fXVTAM29VVvZRCZ29UK1xNFiwD8X7fLRA$> > >> > >> > >> Git Tag for this release: > >> > >> - https://github.com/apache/datasketches-cpp/tree/3.4.0-rc > >> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/3.4.0-rc1__;!!Op6eflyXZCqGR5I!C4Gc0OPbIRXeM6CqcrwntImseB8V3gH4SKgxD7vGd2viTuyC1fXVTAM29VVvZRCZ29UK1xNFiwBzW-7ENw$>1 > >> on branch 3.4.x > >> > >> > >> Git HashId for this release is: 495f6633c1ef9b5bb1e3b5eb32bb9d0f9b48af1e > >> > >> > >> The Release Candidate / Zip Repository, including convenience binaries > >> (in pypi subdirectory): > >> > >> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.4.0-rc1/ > >> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.4.0-rc1/__;!!Op6eflyXZCqGR5I!C4Gc0OPbIRXeM6CqcrwntImseB8V3gH4SKgxD7vGd2viTuyC1fXVTAM29VVvZRCZ29UK1xNFiwBH53IMgA$> > >> > >> > >> The public signing key can be found in the KEYS file: > >> > >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > >> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!C4Gc0OPbIRXeM6CqcrwntImseB8V3gH4SKgxD7vGd2viTuyC1fXVTAM29VVvZRCZ29UK1xNFiwB1SCAWlg$> > >> > >> > >> > >> The artifacts have been signed with key: > >> > >> 21B541A98F6038F334CC 2020-04-30 Jon Malkin (Apache code signing) < > >> [email protected]> > >> > >> > >> Build & Test Guide: > >> > >> - https://github.com/apache/datasketches-cpp/blob/3.4.x/README.md > >> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.4.x/README.md__;!!Op6eflyXZCqGR5I!C4Gc0OPbIRXeM6CqcrwntImseB8V3gH4SKgxD7vGd2viTuyC1fXVTAM29VVvZRCZ29UK1xNFiwABoWqXww$> > >> > >> > >> The vote will be performed as follows: > >> > >> - This letter will be published on dev@ and remain open for at least > >> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) > >> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the > >> community can vote. > >> > >> > >> Please vote accordingly: > >> > >> > >> [ ] +1 approve > >> > >> [ ] +0 no opinion > >> > >> [ ] -1 disapprove with the reason > >> > >> > >> Thanks, > >> > >> Jon Malkin > >> > >> [email protected] > >> > >> > >> > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
