+1 - Checked cmake build test - verified GPG signature - checked SHA checksum - LICENSE, NOTICE files OK
Minor nit (non-blocker): I thought you were going to follow the convention of the -java NOTICE file. On Mon, May 16, 2022 at 1:31 PM Will Lauer <[email protected]> wrote: > +1 > > - verified GPG signature > - checked SHA checksum > - verified python GPG signature for one whl > - checked python SHA checksum for one whl > - cmake, build, test > - install python wheel (cp38 on windows) and spotcheck theta functionality > - build, install, unit test python > - LICENSE, README, and NOTICE file > - python README > - rebuilt and tested internal vertica theta sketch UDFs > > > Minor nit (non-blocker): Python README should include explicit > instructions for running the python unit tests. It says to install tox, but > for completeness, we should have instructions for running tox. > > > > Will Lauer > > > Senior Principal Architect, Audience & Advertising Reporting > > Data Platforms & Systems Engineering > > > M 508 561 6427 > > Champaign Office > > 1908 S. First St > > Champaign, IL 61822 > > > > On Mon, May 16, 2022 at 12:41 AM Jon Malkin <[email protected]> wrote: > >> Hello Apache DataSketches PMC and Community, >> >> >> This is a call for vote to release Apache DataSketches-cpp candidate >> version: 3.4.0-rc1 >> >> >> Changes since rc1: >> >> - fix CMakeLists.txt files to ensure all needed files are properly >> listed for installation >> >> >> Changes since datasketches-cpp 3.3.0 release >> - addition of Quantiles sketch: the algorithm is largely obsolete vs KLL >> but this provides compatibility for existing sketches >> - support for serde instances in all relevant sketches; class-level >> templates are now marked deprecated >> - greater API consistency across quantiles, KLL, and REQ, including new >> get_sorted_view() interface, inclusive mode >> >> - cmake minimum version bump to 3.16 >> >> - Kolmogorov-Smirnov test for KLL and classic Quantiles available in >> python >> >> - code cleanup and bugfixes >> >> >> Source repository: >> >> - https://github.com/apache/datasketches-cpp >> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!AHcys2Rsy0C0poEVgV-qfdDRSLqu_qG_etpVeX5iyeI9SUkk5milbV1QQtHgB1KyC9DOLBuiHnvWsVtaZJA$> >> >> >> Git Tag for this release: >> >> - https://github.com/apache/datasketches-cpp/tree/3.4.0-rc2 >> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/3.4.0-rc2__;!!Op6eflyXZCqGR5I!AHcys2Rsy0C0poEVgV-qfdDRSLqu_qG_etpVeX5iyeI9SUkk5milbV1QQtHgB1KyC9DOLBuiHnvWEgrt7kg$> >> on branch 3.4.x >> >> >> Git HashId for this release is: b0ff65a64f61119a928084d0d2cca227cf62c539 >> >> >> The Release Candidate / Zip Repository, including convenience binaries >> (in pypi subdirectory): >> >> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.4.0-rc2/ >> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.4.0-rc2/__;!!Op6eflyXZCqGR5I!AHcys2Rsy0C0poEVgV-qfdDRSLqu_qG_etpVeX5iyeI9SUkk5milbV1QQtHgB1KyC9DOLBuiHnvWk3Ax88g$> >> >> >> The public signing key can be found in the KEYS file: >> >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!AHcys2Rsy0C0poEVgV-qfdDRSLqu_qG_etpVeX5iyeI9SUkk5milbV1QQtHgB1KyC9DOLBuiHnvWs_DlJ4w$> >> >> >> >> The artifacts have been signed with key: >> >> 21B541A98F6038F334CC 2020-04-30 Jon Malkin (Apache code signing) < >> [email protected]> >> >> >> Build & Test Guide: >> >> - https://github.com/apache/datasketches-cpp/blob/3.4.x/README.md >> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.4.x/README.md__;!!Op6eflyXZCqGR5I!AHcys2Rsy0C0poEVgV-qfdDRSLqu_qG_etpVeX5iyeI9SUkk5milbV1QQtHgB1KyC9DOLBuiHnvW27cQmS8$> >> >> >> The vote will be performed as follows: >> >> - This letter will be published on dev@ and remain open for at least >> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) >> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the >> community can vote. >> >> >> Please vote accordingly: >> >> >> [ ] +1 approve >> >> [ ] +0 no opinion >> >> [ ] -1 disapprove with the reason >> >> >> Thank you, >> >> Jon Malkin >> >> [email protected] >> >
