+1 - verified GPG signature - checked SHA512 sum - cmake, make, make test - tox - reviewed changes in the 3.5.x branch This release candidate looks good to me.
On Mon, Oct 31, 2022 at 1:08 PM Jon Malkin <[email protected]> wrote: > Hello Apache DataSketches PMC and Community, > > > This is a call for vote to release Apache DataSketches-cpp candidate > version 3.5.1-rc2 > > > This is a patch release intended to fix bugs in the previous release. We > are gearing up for some API-breaking changes in a major release, and wanted > to ensure that anyone who is not yet ready for that migration can benefit > from these fixes. > > > Changes since datasketches-cpp 3.5.0 release: > > - fix python wheel build script to produce valid wheels for Apple Silicon > Macs > > - fix a serialization bug for theta and tuple sketches when sketch had no > entries but was not empty (e.g. the result of an intersection between > disjoint sets) > > > Changes since rc1: > > - Should be using the correct GPG signing key (having found my original > one) > > - Source should be entirely unchanged, down to using the same git hashid > > > Change since rc2: > > - Had incorrect version (3.5.0) in CMakeLists.txt > > > Source repository: > > - https://github.com/apache/datasketches-cpp > <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RYm8sIItw$> > > > Git Tag for this release: > > - https://github.com/apache/datasketches-cpp/releases/tag/3.5.1-rc3 > <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/3.5.1-rc3__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RY7N4Kn1A$> > on branch 3.5.x > > > Git HashId for this release is: a44cb33ecdcb310e382d96e81e8a6cb63c044628 > > > The Release Candidate / Zip Repository, including convenience binaries (in > pypi subdirectory): > > - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.1-rc3/ > <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.1-rc3/__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RYHzjJfpg$> > > > The public signing key can be found in the KEYS file: > > - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> > > > > The artifacts have been signed with key: > > 21B541A98F6038F334CC 2020-04-30 Jon Malkin (Apache code signing) < > [email protected]> > > > Build & Test Guide (C++): > > - https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md > <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbqyvNl8Q$> > > > Build & Test Guide (Python): > > - > https://github.com/apache/datasketches-cpp/blob/3.5.x/python/README.md > <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.5.x/python/README.md__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbT2jK7dQ$> > > > The vote will be performed as follows: > > - This letter will be published on dev@ and remain open for at least > 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC > votes or a majority of (+1) PMC votes are acquired. Anyone in the > community can vote. > > > Please vote accordingly: > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > Thank you, > > Jon Malkin > > [email protected] >
