-1 (binding) Everything checked out and looks good following the usual checks.
But for some reason this forced an update to a minimum version of maven 3.9.1, which is a problem. I had to manually install the latest version on my linux box, as that version isn't even 2 months old. That's not an option for a significant number of build systems -- plenty of organizations like to build from source rather than trusting what's in maven central. And assuming entities have all updated their build platforms to that recent a release is not reasonable. Plugin versions can be updated more aggressively since those can be downloaded automatically. Maven itself is different and we need to provide a reason why people running a version 3 months old would be prohibited from building this. I did not find a PR explaining that and this change seems to have been introduced in an unreviewed "revert" commit. jon On Fri, May 12, 2023 at 2:54 PM Lee Rhodes <[email protected]> wrote: > +1 (binding) > > I checked: > - LICENCE, NOTICE and README OK > - GPG and SHA signatures OK > - build and install locally (mac ventura 13.3.1, Apple M1 Pro) - > registered extension in test database, Success > - basic CPC sketch test with 1 value, Success > > On Thu, May 11, 2023 at 11:38 AM Lee Rhodes <[email protected]> wrote: > >> 1. This is a call for vote to release Apache DataSketches-java candidate >> version: 4.0.0-RC2 >> >> NOTE: This is the core Java component of the DataSketches library >> that includes all the sketch algorithms in production-ready packages. These >> sketches can be called directly from this component or used in conjunction >> with the adaptor components such as Hadoop Pig, Hadoop Hive, or the >> aggregator adaptors built into Apache Druid. >> >> MAJOR NEW FEATURES AND ENHANCEMENTS FOR USERS >> - Quantile Sketches >> - The major APIs for all the quantile sketches now derive from >> interfaces common to all the quantile sketches. This makes it much easier >> for the user to move from one quantile sketch to another with only very >> minor code changes. >> - All the quantile sketches now have a "SortedView", which is >> iterable and makes analysis of the quantile distribution even easier. >> - HLL Sketches >> - Major speed performance improvements for HLL union/merge >> operations. >> - Major improvements to the HLL Javadocs. >> - Theta Sketches >> - The Theta sketch has been enhanced with an optional compress >> operation that makes the serialized theta sketch smaller. >> - TestNG has been updated to version 7.5.1 (works with Java 8), which >> includes the Zip Slip Vulnerability. >> >> 2. Source repository: >> - https://github.com/apache/datasketches-java >> >> Git Tag for this release: >> - https://github.com/apache/datasketches-java/tree/4.0.0-RC2 on >> branch 4.0.X >> >> Git Commit Id for this release starts with: a8405d9 >> >> 3. The Release Candidate / Zip Repository: >> - https://dist.apache.org/repos/dist/dev/datasketches/java/4.0.0-RC2/ >> >> The public signing key can be found in the KEYS file: >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >> >> The artifacts have been signed with --keyid-format SHORT : 8CD4A902 >> >> 4. Repository: Maven Central [Nexus](http://repository.apache.org) (Jar >> Artifacts): >> - >> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/4.0.0/ >> >> 5. Build & Test Guide: >> - >> https://github.com/apache/datasketches-java/blob/4.0.0-RC2/README.md >> >> 6. The vote will be performed as follows: >> - This letter will be published on dev@ and remain open for at least >> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >> votes or a majority of (+1) PMC votes are acquired. Anyone in the community >> can vote. >> >> Please vote accordingly: >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove with the reason >> >> Thanks, >> Lee Rhodes >> [email protected] >> >
