+1
Checked gpg and shasum
Ran unit tests
Checked printing of density sketch in ipython and it worked fine this time

On Thu, 1 Feb 2024 at 18:50, Alexander Saydakov
<[email protected]> wrote:

> +1
>
> - checked GPG and SHA512 signatures
> - reviewed changes since rc1
> - run "tox" successfully
>
> On Wed, Jan 31, 2024 at 10:47 PM Jon Malkin <[email protected]> wrote:
>
>> Hello Apache DataSketches PMC and Community,
>>
>>
>> This is a call for vote to release Apache DataSketches-python candidate
>> version 5.0.0-rc2
>>
>>
>> This will be the first stand-alone Python release, although continuing
>> the version numbering used when this portion of the project was bundled
>> with the C++ release.
>>
>>
>> This is also a major version release with several significant changes:
>> * Vastly improved API documentation via sphinx
>> * More pythonic API:
>>   * __copy__ instead of C++-style copy constructors
>>   * __str__ takes no arguments in all cases
>> * Moved from pybind11 to nanobind, which also requires c++17 internally
>> * Added new exact proportional to size sampling sketch, ebpps_sketch
>> * Fixed slowness with theta intersection
>> * Fixed incompatibility with Java's serialized empty frequent items sketch
>> * Removed default Kernel for density sketch (GaussianKernel is still
>> provided)
>> * Removed extra (largely transparent to users) wrappers around
>> density_sketch and tuple_sketch
>>
>> Changes from rc1:
>> * Fixed object leaks with KernelFunction and TuplePolicy objects
>> * Fixed all __str__ methods to perform as intended
>> * Added NOMINSIZE to nanobind config, increasing performance at the cost
>> of a slightly larger wheel
>>
>> Source repository:
>>
>>     - https://github.com/apache/datasketches-python
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python__;!!Op6eflyXZCqGR5I!HYf1mhX9VTSyJ_DYhAnDrZNC4tskivLekssJDjdX3i4mQk4fsgVSukkqr3Tlv7AGYqp4Z9c_VTV0-oZ4lw$>
>>
>>
>> Git Tag for this release:
>>
>>     -
>> https://github.com/apache/datasketches-python/releases/tag/5.0.0-rc2
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python/releases/tag/5.0.0-rc2__;!!Op6eflyXZCqGR5I!HYf1mhX9VTSyJ_DYhAnDrZNC4tskivLekssJDjdX3i4mQk4fsgVSukkqr3Tlv7AGYqp4Z9c_VTXeRXq2Rg$>
>>  on
>> branch 5.0.x
>>
>>
>> Git HashId for this release is: 28a560240a72cf3451d9024c4ffb87c476997da7
>>
>>
>> The Release Candidate Zip Repository:
>>
>>     -
>> https://dist.apache.org/repos/dist/dev/datasketches/python/5.0.0-rc2/
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/python/5.0.0-rc2/__;!!Op6eflyXZCqGR5I!HYf1mhX9VTSyJ_DYhAnDrZNC4tskivLekssJDjdX3i4mQk4fsgVSukkqr3Tlv7AGYqp4Z9c_VTUureT_xw$>
>>
>>
>> The public signing key can be found in the KEYS file:
>>
>>     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>>
>>
>>
>> The artifacts have been signed with key:
>>
>>     41A98F6038F334CC Jon Malkin (Apache code signing) <
>> [email protected]>
>>
>>
>> Build & Test Guide:
>>
>>     -
>> https://github.com/apache/datasketches-python/blob/5.0.0-rc2/README.md
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python/blob/5.0.0-rc2/README.md__;!!Op6eflyXZCqGR5I!HYf1mhX9VTSyJ_DYhAnDrZNC4tskivLekssJDjdX3i4mQk4fsgVSukkqr3Tlv7AGYqp4Z9c_VTVymMd2bg$>
>>
>>
>> The vote will be performed as follows:
>>
>>    - This letter will be published on dev@ and remain open for at least
>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
>> votes or a majority of (+1) PMC votes are acquired. Anyone in the
>> community can vote.
>>
>>
>> Please vote accordingly:
>>
>>
>> [ ] +1 approve
>>
>> [ ] +0 no opinion
>>
>> [ ] -1 disapprove with the reason
>>
>>
>> Thank you,
>>
>> Jon Malkin
>>
>> [email protected]
>>
>

Reply via email to