ZacBlanco commented on code in PR #162:
URL:
https://github.com/apache/datasketches-website/pull/162#discussion_r1509546456
##########
docs/Architecture/LargeScale.md:
##########
@@ -33,7 +33,9 @@ layout: doc_page
* The C++ Core is extended using the python binding library
[pybind11](https://github.com/pybind/pybind11) enabling high performance
operation from Python.
### Cross Language Binary Compatibility
-* Sketches serialized from C++ or Python can be interpreted by compatible Java
sketches and visa versa.
+* Sketches serialized from C++ or Python can be interpreted by compatible Java
sketches and visa versa.
+
+* All sketches have a serialized form which is able to be deserialized by any
version of the library since the sketch was introduced.
Review Comment:
Thank you for the thorough response @leerho. I agree with you that it's
impossible to always difficult to predict the future, I just wanted to better
understand the intentions of the datasketches maintainers when it comes to
serialization compatibility. I think you've answered all my the questions
though.
For this change I think there are two parts to highlight (1) is the
compatibility across languages and (2) is compatibility across datasketches
versions. I've split your suggestions above across bullets pertaining to those
points and tried to word it accordingly.
##########
docs/Architecture/LargeScale.md:
##########
@@ -33,7 +33,9 @@ layout: doc_page
* The C++ Core is extended using the python binding library
[pybind11](https://github.com/pybind/pybind11) enabling high performance
operation from Python.
### Cross Language Binary Compatibility
-* Sketches serialized from C++ or Python can be interpreted by compatible Java
sketches and visa versa.
+* Sketches serialized from C++ or Python can be interpreted by compatible Java
sketches and visa versa.
+
+* All sketches have a serialized form which is able to be deserialized by any
version of the library since the sketch was introduced.
Review Comment:
Thank you for the thorough response @leerho. I agree with you that it's
always difficult to predict the future, I just wanted to better understand the
intentions of the datasketches maintainers when it comes to serialization
compatibility. I think you've answered all my the questions though.
For this change I think there are two parts to highlight (1) is the
compatibility across languages and (2) is compatibility across datasketches
versions. I've split your suggestions above across bullets pertaining to those
points and tried to word it accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
