I decided that the issue @Jon Malkin <jmal...@yahooinc.com> found, not building with Java 11, needed to be fixed. As a result:
- I am suspending the vote on RC1 - I will submit an RC2 that fixes the issue. On Fri, May 24, 2024 at 1:45 PM Jon Malkin <jon.mal...@gmail.com> wrote: > +1 (binding) > > I checked: > - hashes and signatures, including convenience binaries > - all tests pass > - single-version jar script successfully built (did not test in a project) > - mvn package successful > > In order to get things working, I had to explicitly run maven with java 8. > Otherwise I got an error about not being able to export certain classes > when using the --release flag. I don't think it's a blocker (hence the +1 > vote), but it's not ideal to force someone to install 8. That said, if we > move the datasketches-java repo to use Java 17+ this whole project becomes > obsolete so maybe it's not such a big deal. > > jon > > On Tue, May 21, 2024 at 2:56 PM Lee Rhodes <lee...@gmail.com> wrote: > >> ### Bug Fix: datasketcches-memory Issues #178 >> ### Updated POM to fix Eclipse Java Build Path issues >> ### Updated POM plugins and GitHub actions versions to recent releases >> >> Hello Apache DataSketches PMC and Community, >> >> 1. This is a call for vote to release Apache DataSketches-memory >> candidate version: 2.2.1-RC1 >> >> 2. Source repository: >> -https://github.com/apache/datasketches-memory >> >> Git Tag for this release: >> - https://github.com/apache/datasketches-memory/tree/2.2.1-RC1 on >> branch 2.2.X >> >> Git HashId for this release starts with: 22169e6 >> >> 3. The Release Candidate / Zip Repository: >> - >> https://dist.apache.org/repos/dist/dev/datasketches/memory/2.2.1-RC1/ >> >> The public signing key can be found in the KEYS file: >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >> >> The artifacts have been signed with --keyid-format SHORT : 8CD4A902 >> >> 4. Repository: Maven Central [Nexus](http://repository.apache.org) (Jar >> Artifacts): >> - >> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-memory/2.2.1/ >> >> 5. Build & Test Guide: >> - >> https://github.com/apache/datasketches-memory/blob/2.2.1-RC1/README.md >> >> 6. The vote will be performed as follows: >> - This letter will be published on dev@ and remain open for >> - at least 72 hours (excluding weekends and holidays), AND >> - until at least 3 (+1) PMC votes or a majority of (+1) PMC votes >> are acquired. >> - Anyone in the community can vote. >> - This vote will close no earlier than Thursday, May 23, 2024, 5:00 >> PM PST. >> >> Please vote accordingly: >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove with the reason >> >> Thanks, >> Lee Rhodes >> lee...@apache.org >> >
