+1 - signature and checksum good - LICENSE and NOTICE seem good - tested "mvn clean test" with java 8 and 11, which passed - tested "mvn clean test" with java 17, which failed (expected)
The 17 test failed with a slightly cryptic message about "release version 1.8 not supported." Testing on 21, by contrast, included 17 in the acceptable versions list. My understanding is that we should be able to use the compiled jar from 17 as long as we do not need direct memory but may not be able to compile in 17. So I'm counting this as ok. jon On Wed, Sep 11, 2024 at 11:38 AM Alexander Saydakov <[email protected]> wrote: > +1 > > - GPG signature OK > - SHA512 OK > - LICENSE and NOTICE look fine > - "mvn test" passes (openjdk 11) > > > On Wed, Sep 11, 2024 at 9:23 AM Charlie Dickens > <[email protected]> wrote: > >> checked shasum and keys >> mvn clean test passed in java 8, 11. >> mvn clean test failed in java 17. >> +1 >> >> On Wed, 11 Sept 2024 at 17:11, Lee Rhodes <[email protected]> wrote: >> >>> Oops! I didn't completely edit the links to go to the correct RC2 >>> version. My bad! Here is the updated links of the letter: >>> 2. Source repository: >>> - https://github.com/apache/datasketches-java >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BHMt9v_0$> >>> >>> Git Tag for this release: >>> - https://github.com/apache/datasketches-java/releases/tag/6.1.0-RC >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/releases/tag/6.1.0-RC2__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BhGmLJjk$>2 >>> on branch 6.1.X >>> >>> Git HashId for this release starts with: ba47011 on branch 6.1.X >>> >>> 3. The Release Candidate / Zip Repository: >>> - https://dist.apache.org/repos/dist/dev/datasketches/java/6.1.0-RC >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/java/6.1.0-RC2__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BE948BDs$> >>> 2 >>> >>> The public signing key can be found in the KEYS file: >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6Baff6qCY$> >>> >>> The artifacts have been signed with --keyid-format SHORT : 8CD4A902 >>> >>> 4. Repository: Maven Central [Nexus](http://repository.apache.org >>> <https://urldefense.com/v3/__http://repository.apache.org/__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6B8avdizE$>) >>> (Jar Artifacts): >>> - >>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/6.1.0/ >>> <https://urldefense.com/v3/__https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/6.1.0/__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BnfOFy0Q$> >>> >>> 5. Build & Test Guide: >>> - >>> https://github.com/apache/datasketches-java/blob/6.1.0-RC2/README.md >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/blob/6.1.0-RC2/README.md__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BdIaaDps$> >>> >>> >>> On Wed, Sep 11, 2024 at 8:57 AM Jon Malkin <[email protected]> wrote: >>> >>>> The link text in this email say RC2 but the links actually go to the >>>> RC1 tag, repo, and readme. Can we please update to provide the correct >>>> links? >>>> >>>> On Thu, Sep 5, 2024 at 6:52 PM Lee Rhodes <[email protected]> wrote: >>>> >>>>> Hello Apache DataSketches PMC and Community, >>>>> >>>>> ### Added new KLL Longs Sketch >>>>> ### Optimized HLL Union for merge HLL to HLL >>>>> ### Change Memory dependency to version 3.0.0 >>>>> ### Added one exclusion to FindBugsExcludeFilter.xml >>>>> ### Updated Memory dependency version to 3.0.1 >>>>> ### Fixed bug in Memory that was preventing limited runtime operation >>>>> with Java 17, see Memory PR#209. >>>>> (Java 17 is not formally supported by Memory. See Memory README). >>>>> >>>>> 1. This is a call for vote to release Apache DataSketches-java >>>>> candidate version: 6.1.0-RC2 >>>>> >>>>> NOTE 1: This is the core Java component of the DataSketches >>>>> library that includes all the sketch algorithms in production-ready >>>>> packages. These sketches can be called directly from this component or >>>>> used >>>>> in conjunction with the adaptor components such as Hadoop Pig, Hadoop >>>>> Hive, >>>>> or the aggregator adaptors built into Apache Druid. >>>>> >>>>> 2. Source repository: >>>>> - https://github.com/apache/datasketches-java >>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BHMt9v_0$> >>>>> >>>>> Git Tag for this release: >>>>> - >>>>> https://github.com/apache/datasketches-java/releases/tag/6.1.0-RC >>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/releases/tag/6.1.0-RC1__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BVU1VFqY$>2 >>>>> on branch 6.1.X >>>>> >>>>> Git HashId for this release starts with: ba47011 on branch 6.1.X >>>>> >>>>> 3. The Release Candidate / Zip Repository: >>>>> - >>>>> https://dist.apache.org/repos/dist/dev/datasketches/java/6.1.0-RC >>>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/java/6.1.0-RC1__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6Bm4ahPM8$> >>>>> 2 >>>>> >>>>> The public signing key can be found in the KEYS file: >>>>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6Baff6qCY$> >>>>> >>>>> The artifacts have been signed with --keyid-format SHORT : 8CD4A902 >>>>> >>>>> 4. Repository: Maven Central [Nexus](http://repository.apache.org >>>>> <https://urldefense.com/v3/__http://repository.apache.org/__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6B8avdizE$>) >>>>> (Jar Artifacts): >>>>> - >>>>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/6.1.0/ >>>>> <https://urldefense.com/v3/__https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/6.1.0/__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BnfOFy0Q$> >>>>> >>>>> 5. Build & Test Guide: >>>>> - >>>>> https://github.com/apache/datasketches-java/blob/6.1.0-RC2/README.md >>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/blob/6.1.0-RC1/README.md__;!!Op6eflyXZCqGR5I!C-d4KqpmdyhUEHN2fz4bQGeuH3tozyKuXeY-A9rz1-FsSLVA1MIrqLElBBGuE2deWLgcPn9k_dtKtx6BtESEIG0$> >>>>> >>>>> 6. The vote will be performed as follows: >>>>> - This letter will be published on dev@ and remain open for at >>>>> least 72 hours (excluding weekends and holidays), AND until at least 3 >>>>> (+1) >>>>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the >>>>> community can vote. This vote will close no earlier than Tuesday, Sep 10, >>>>> 2024, 7:00 PM PST. >>>>> >>>>> Please vote accordingly: >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove with the reason >>>>> >>>>> Thanks, >>>>> Lee Rhodes >>>>> [email protected] >>>>> >>>>
