AlexanderSaydakov commented on code in PR #35: URL: https://github.com/apache/datasketches-bigquery/pull/35#discussion_r1757637658
########## kll/sqlx/kll_sketch_float_get_rank.sqlx: ########## @@ -24,12 +24,19 @@ RETURNS FLOAT64 LANGUAGE js OPTIONS ( library=["gs://$GCS_BUCKET/kll_sketch.js"], - description = '''Returns an approximation to the normalized rank of the given value. from 0 to 1, inclusive. + description = '''Returns an approximation to the normalized rank, on the interval (0.0, 1.0], of the given value. Review Comment: why zero is not included? the rank can be zero -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
