leerho commented on code in PR #46:
URL:
https://github.com/apache/datasketches-bigquery/pull/46#discussion_r1767912741
##########
tuple/sqlx/tuple_sketch_int64_a_not_b.sqlx:
##########
@@ -21,6 +21,19 @@ config { hasOutput: true }
CREATE OR REPLACE FUNCTION ${self()}(sketchA BYTES, sketchB BYTES)
RETURNS BYTES
+OPTIONS (
+ description = '''Computes a sketch that represents the scalar set difference
of sketchA and not sketchB.
+Cardinality estimation accuracy, plots, error tables, and p value are the same
as the Theta Sketch.
+This function only applies to Tuple Sketches with an INT64 summary column.
+
+Param sketchA: the first sketch "A" as BYTES. This may not be NULL.
+Param sketchB: the second sketch "B" as BYTES. This may not be NULL.
+Param seed: assume default = 9001
Review Comment:
It is important to state what the assumed value is. So somewhere I would
have to list the assumed parameters. I figured this list of params was as good
as any. If you are still uncomfortable I could do this instead:
```
Param sketchA: the first sketch "A" as BYTES. This may not be NULL.
Param sketchB: the second sketch "B" as BYTES. This may not be NULL.
Assumed Default Param seed = 9001
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
