AlexanderSaydakov opened a new issue, #72: URL: https://github.com/apache/datasketches-bigquery/issues/72
There are several questions regarding naming. 1. For BigQuery integration we have a request to change the names of our artifacts which clash with existing ones in BQ repo. They are kll_sketch.cpp (and resulting js, mjs and wasm) and theta_sketch.cpp 2. Currently we have only one set of functions for each sketch family, but we may want to have more. For instance, we have tuple_sketch_int64.cpp with corresponding set of sqlx functions sharing the same prefix, and may want to have one more set of functions for some other tuple sketch such as tuple_sketch_array_of_doubles or similar. I am inclined to rename kll_sketch.cpp into kll_sketch_float.cpp to address the first problem and to be consistent with the prefix that all functions share now. We may want to have another set later for kll_sketch_double. The theta_sketch.cpp name clashes with the existing one in BQ repo, so we need to think of some other name at least for some transition period. I suggest theta.cpp for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For additional commands, e-mail: dev-h...@datasketches.apache.org
