nikunjbhartia opened a new pull request, #81:
URL: https://github.com/apache/datasketches-bigquery/pull/81
1) In *tests.sql files: $BQ_DATASET -> `$BQ_DATASET` to ensure queries don't
fails if dataset contains special characters
2) In substitute_and_run.sh: `bq query ..` -> `bq --project_id $BQ_PROJECT
query ..`
Since *_test.sql files don't have project qualified datasets, above flag
in bq cli ensures all test queries are run in the project where UDFs are
created, otherwise they might default to the project defined in local gcloud
configs
3) updated Makefile `test` task to continue execution on error by adding `-`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For additional commands, e-mail: dev-h...@datasketches.apache.org
