+1 (binding) - built and tested clean - LICENSE and NOTICE seem good - checksum and signature good for both main zip and wheels - wheels support python 3.9 - 3.13
jon On Tue, Dec 10, 2024 at 10:11 AM Lee Rhodes <lee...@gmail.com> wrote: > +1 (binding) > > - downloaded successfully > - ran tox with no errors > - LICENSE and NOTICE look good > > > On Mon, Dec 9, 2024 at 2:26 PM Alexander Saydakov > <sayda...@yahooinc.com.invalid> wrote: > >> +1 >> >> - LICENSE and NOTICE look good >> - checked GPG signature and SHA hash >> - tox tests run fine >> - convenience wheels contain Python version 3.13, which was the goal of >> this release >> >> On Sun, Dec 8, 2024 at 1:05 AM Jon Malkin <jmal...@apache.org> wrote: >> >>> Hello Apache DataSketches PMC and Community, >>> >>> >>> This is a call for vote to release Apache DataSketches-python candidate >>> version 5.1.1-rc1. >>> >>> >>> This is a patch release that adds wheels for python 3.13 and removes >>> them for the now-EOLed 3.8. There should be no additional changes. >>> >>> Known issue: The documentation still does not mention t-digest, although >>> the sketch is available. >>> >>> >>> Source repository: >>> >>> - https://github.com/apache/datasketches-python >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python__;!!Op6eflyXZCqGR5I!C6HWDMf5IR6mK6IhbmVO9UleTK83WWj-npqcqotSk-jF-gjSduF2kit6Kd63IFHGL9a4y1RsmudAol_1Bg$> >>> >>> >>> Git Tag for this release: >>> >>> - >>> https://github.com/apache/datasketches-python/releases/tag/5.1.1-rc1 >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python/releases/tag/5.1.1-rc1__;!!Op6eflyXZCqGR5I!C6HWDMf5IR6mK6IhbmVO9UleTK83WWj-npqcqotSk-jF-gjSduF2kit6Kd63IFHGL9a4y1RsmuclbOOMGw$> >>> on >>> branch 5.1.x >>> >>> >>> Git HashId for this release is: bb9e6a415063e5b76bf20110a165c12faa590e50 >>> >>> >>> The Release Candidate Zip Repository: >>> >>> - >>> https://dist.apache.org/repos/dist/dev/datasketches/python/5.1.1-rc1/ >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/python/5.1.1-rc1/__;!!Op6eflyXZCqGR5I!C6HWDMf5IR6mK6IhbmVO9UleTK83WWj-npqcqotSk-jF-gjSduF2kit6Kd63IFHGL9a4y1Rsmud-iYeHAw$> >>> >>> >>> The public signing key can be found in the KEYS file: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> >>> >>> >>> >>> The artifacts have been signed with key: >>> >>> 41A98F6038F334CC Jon Malkin (Apache code signing) < >>> jmal...@users.noreply.github.com> >>> >>> >>> Build & Test Guide: >>> >>> - >>> https://github.com/apache/datasketches-python/blob/5.1.1-rc1/README.md >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python/blob/5.1.1-rc1/README.md__;!!Op6eflyXZCqGR5I!C6HWDMf5IR6mK6IhbmVO9UleTK83WWj-npqcqotSk-jF-gjSduF2kit6Kd63IFHGL9a4y1Rsmud5RhGI5A$> >>> >>> - For voters who may be less familiar with python but want to test >>> installing an appropriate wheel or using pip to install from source, >>> remember to create a virtual environment before testing. For example: >>> >>> > python -m venv venv >>> >>> > source venv/bin/activate >>> >>> and then proceed with the installation. >>> >>> >>> The vote will be performed as follows: >>> >>> - This letter will be published on dev@ and remain open for at least >>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >>> votes or a majority of (+1) PMC votes are acquired. Anyone in the >>> community can vote, and is encouraged to do so. >>> >>> - The vote will not close before Thursday, 12 December 2024, 12:00am >>> PST (US Pacific Time). >>> >>> >>> Please vote accordingly: >>> >>> >>> [ ] +1 approve >>> >>> [ ] +0 no opinion >>> >>> [ ] -1 disapprove with the reason >>> >>> >>> Thank you, >>> >>> Jon Malkin >>> >>> jmal...@apache.org >>> >>
