This was a brand new directory. I did choose to install emsdk here instead of somewhere else. I wasn't sure where else to put it. Not sure about the others.
On Fri, Dec 13, 2024 at 4:08 PM Alexander Saydakov <sayda...@yahooinc.com.invalid> wrote: > I am not aware of 'emsdk' and 'includes'. Perhaps those are in your own > environment? > We can remove the .zip after extraction. That would be a slight change to > Makefile. > workflow_settings.yaml is not in version control. I think it is a > temporary file, side effect of running some cloud utils. > > On Fri, Dec 13, 2024 at 3:55 PM Lee Rhodes <lee...@gmail.com> wrote: > >> +1(binding) >> >> Whew! I made it through all the way to "make test" and everything passed! >> >> I have a couple of minor comments, which should not impact the release: >> >> - In the README.md file there needs to be a blank line prior to "``` >> .... ```" blocks. Although these blocks rendered ok in Chrome, these >> blocks may not render in all browsers. I use MacDown to check these kinds >> of formatting issues. >> - The root directory is looking messy with all of the build related >> stuff in it. The user's attention should be focused on the sketch >> directories and the following directories and files distract from that: >> - CICD/ >> - datasketches-cpp/ (sym-link) >> - datasketches-cpp-5.1.0/ >> - emsdk/ >> - includes/ >> - cloudbuild.yaml >> - datasketches-cpp-5.1.0.zip >> - readme_generator.py >> - substitute_and_run.sh >> - workflow_settings.yaml >> >> Can most of this stuff be put in a "build" directory? >> >> >> >> On Wed, Dec 11, 2024 at 2:20 PM Alexander Saydakov >> <sayda...@yahooinc.com.invalid> wrote: >> >>> Hello Apache DataSketches PMC and Community, >>> >>> >>> This is a call for vote to release >>> Apache DataSketches-bigquery candidate version 1.0.0-rc1 >>> >>> Apache DataSketches library functions for Google BigQuery. >>> >>> This is the first release of the product. >>> >>> Source repository: >>> >>> - https://github.com/apache/datasketches-bigquery >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDkts3l-n_iU$> >>> >>> >>> Git Tag for this release: >>> >>> - >>> https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1 >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDktsTs6TUPo$> >>> on >>> branch 1.0.x >>> >>> >>> Git HashId for this release is: 407ae7519e10b3f8e5965cad2c9de5475a8bb444 >>> >>> The Release Candidate Zip Repository: >>> >>> - >>> https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/ >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDktsG43CGGo$> >>> >>> >>> The public signing key can be found in the KEYS file: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> >>> >>> >>> >>> The artifacts have been signed with key: >>> >>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < >>> al...@apache.org> >>> >>> >>> Build & Test Guide: >>> >>> - >>> https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDkts_CSTMpg$> >>> >>> >>> The vote will be performed as follows: >>> >>> - This letter will be published on dev@ and remain open for at least >>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >>> votes or a majority of (+1) PMC votes are acquired. Anyone in the >>> community can vote. >>> >>> >>> Please vote accordingly: >>> >>> >>> [ ] +1 approve >>> >>> [ ] +0 no opinion >>> >>> [ ] -1 disapprove with the reason >>> >>> >>> Thank you, >>> >>> Alexander Saydakov >>> >>> al...@apache.org >>> >>> >>>
