jmalkin commented on PR #3: URL: https://github.com/apache/datasketches-spark/pull/3#issuecomment-2573968618
I think the uses were weakly tied together by the return type in the aggregations, which is KllDoublesSketchType. With that previously based on the wrapper, it was cleaner to remove the extra layer of indirection everywhere. It may not be necessary with the java library where distinct counting unions also accept raw updates, but if we need to use a complex Option[sketch]+Option[union] object then the separation between those use cases would be more obvious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For additional commands, e-mail: dev-h...@datasketches.apache.org
