+1 (binding) - GPG & SHA512 are OK - NOTICE & LICENSE OK - 'mvn clean test' passes - I confirmed that Java 17 FFM compiled code will not run under Java 21. This is because the location of the FFM *incubation* code was moved from *jdk.incubator.foreign* to its final position for *preview* at *java.base/java.lang.foreign*. Java does not guarantee backward compatibility for older "incubation" code.
On Tue, Jan 7, 2025 at 9:41 AM Jon Malkin <jon.mal...@gmail.com> wrote: > +1 > > - GPG and SHA look good, including in maven subdir > - LICENSE and NOTICE are ok > - mvn test works with java 17, fails on older (expected) > > jon > > On Mon, Jan 6, 2025 at 1:20 PM Alexander Saydakov > <sayda...@yahooinc.com.invalid> wrote: > > > > +1 > > > > - checked GPG signature and SHA hash > > - LICENSE and NOTICE look fine (do we need to update 2024 to 2025?) > > - "mvn test" successful with openjdk 17.0.13 > > > > > > On Sun, Jan 5, 2025 at 4:25 PM Lee Rhodes <lee...@gmail.com> wrote: > >> > >> Please ignore the mention of Apache Spark in the note attached to > paragraph 1. We have not yet released an adaptor for Apache Spark. > >> > >> Lee. > >> > >> On Sat, Jan 4, 2025 at 10:30 AM Lee Rhodes <lee...@gmail.com> wrote: > >>> > >>> NOTE: This version of DataSketches-java requires Java 17 and leverages > the new Panama (FFM) incubation capability introduced with Java 17 and JEP > 412. > >>> As a result, you may need to add > "--add-modules=jdk.incubator.foreign" as a run-time flag to the JVM. > >>> > >>> Hello Apache DataSketches PMC and Community, > >>> > >>> 1. This is a call for vote to release Apache DataSketches-java > candidate version: 7.0.0-RC1. > >>> > >>> NOTE 1: This is the core Java component of the DataSketches > library that includes all the sketch algorithms in production-ready > packages. These sketches can be called directly from this component or used > in conjunction with the adaptor components such as Hadoop Pig, Hadoop Hive, > Apache Spark, the aggregator adaptors built into Apache Druid, etc. > >>> > >>> 2. Source repository: > >>> - https://github.com/apache/datasketches-java > >>> > >>> Git Tag for this release: > >>> - > https://github.com/apache/datasketches-java/releases/tag/7.0.0-RC1 on > branch 7.0.X > >>> > >>> Git HashId for this release starts with: e37a4a7 on branch 7.0.X > >>> > >>> 3. The Release Candidate / Zip Repository: > >>> - > https://dist.apache.org/repos/dist/dev/datasketches/java/7.0.0-RC1 > >>> > >>> The public signing key can be found in the KEYS file: > >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > >>> > >>> The artifacts have been signed with --keyid-format SHORT : 8CD4A902 > >>> > >>> 4. Repository: Maven Central [Nexus](http://repository.apache.org) > (Jar Artifacts): > >>> - > https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/7.0.0/ > >>> > >>> 5. Build & Test Guide: > >>> - > https://github.com/apache/datasketches-java/blob/7.0.0-RC1/README.md > >>> > >>> 6. The vote will be performed as follows: > >>> - This letter will be published on dev@ and remain open for at > least 72 hours (excluding weekends and holidays), AND until at least 3 (+1) > PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the > community can vote. This vote will close no earlier than Wednesday Jan 8, > 2025, 5:00 PM PST. > >>> > >>> Please vote accordingly: > >>> > >>> [ ] +1 approve > >>> [ ] +0 no opinion > >>> [ ] -1 disapprove with the reason > >>> > >>> Thanks, > >>> Lee Rhodes > >>> lee...@apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org > For additional commands, e-mail: dev-h...@datasketches.apache.org > >
