AlexanderSaydakov commented on code in PR #24:
URL: https://github.com/apache/datasketches-spark/pull/24#discussion_r1978577977
##########
examples/airflow/install_wheels.sh:
##########
@@ -30,8 +30,8 @@ export JAR_PATH=/opt/datasketches_jars
#os.environ['PYSPARK_SUBMIT_ARGS'] = f"--driver-java-options '{java_opts}'
pyspark-shell"
# download wheels from GCS buckets
-gsutil cp gs://jmalkin_ds_spark/${DSPY_PACKAGE} /tmp/
-gsutil cp gs://jmalkin_ds_spark/${DSSPARK_PACKAGE} /tmp/
+gsutil cp gs://GCS_BUCKET_NAME/${DSPY_PACKAGE} /tmp/
+gsutil cp gs://GCS_BUCKET_NAME/${DSSPARK_PACKAGE} /tmp/
Review Comment:
should they be variables like ${GCS_BUCKET_NAME}?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For additional commands, e-mail: dev-h...@datasketches.apache.org
