jmalkin commented on code in PR #143: URL: https://github.com/apache/datasketches-bigquery/pull/143#discussion_r1989821983
########## README.md: ########## @@ -108,21 +108,24 @@ Run the following steps in this repo's root directory to install everything: ```bash gcloud auth application-default login # for authentication -make # performs compilation -make install # upload to $JS_BUCKET & create functions in $BQ_PROJECT.$BQ_DATASET -make test # runs predefined tests in BQ +make # compile C++ code and produce .js, .mjs and .wasm artifacts +make install # upload artifacts to $JS_BUCKET and create SQLX functions in $BQ_PROJECT.$BQ_DATASET +make test # run tests in BigQuery ``` +The "install" target consists of "upload" and "create", which can be used separately if desired + ### Install Specific DataSketches -To install a specific sketch, change into an individual sketch directory and run -the following: +To install a specific sketch use rargets or the form dir.target. Review Comment: typo: `rargets` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For additional commands, e-mail: dev-h...@datasketches.apache.org
