AlexanderSaydakov commented on issue #145: URL: https://github.com/apache/datasketches-bigquery/issues/145#issuecomment-2718778337
This issue is slightly different. I addressed aggregate functions here: #140 Now aggregate functions always produce a sketch. Input of all nulls results in an empty sketch. This issue is about better handling in scalar functions. I agree that we can do better (at least give a better error message). I am inclined to require valid sketches in scalar functions. This is debatable, of course. We can look at how we handle this in other systems like Hive, Pig, Druid and such. Given that aggregates always produce a sketch, there should be no problem doing things like: get_estimate(union(column of nulls)) - this will result in 0 estimate a_not_b(union(nulls), union(nulls)) - this will produce empty sketch and so on -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For additional commands, e-mail: dev-h...@datasketches.apache.org
