AlexanderSaydakov commented on issue #146: URL: https://github.com/apache/datasketches-bigquery/issues/146#issuecomment-2722442588
My mistake, no doubt, but this transition complicates things unnecessarily in my view. It leads to more complicated code with merging in aggregate, which in some cases such as Theta sketch might slow things down. Performing a union is expensive, and it does not belong to aggregate stage at all. In Frequent Items the overhead is not bad, but still this special code path, which is not always tested is annoying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For additional commands, e-mail: dev-h...@datasketches.apache.org
