freakyzoidberg commented on code in PR #29:
URL: https://github.com/apache/datasketches-go/pull/29#discussion_r2001726002
##########
cpc/cpc_sketch.go:
##########
@@ -513,3 +535,149 @@ func (c *CpcSketch) ToCompactSlice() ([]byte, error) {
return (byte[]) wmem.getArray();
}
*/
+
+// GetFamily returns the CPC family identifier.
+func (c *CpcSketch) GetFamily() internal.Family {
Review Comment:
We can't expose internal package.
for now, just remove that GetFamily - we ll need to find a way to expose
that across all sketches properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For additional commands, e-mail: dev-h...@datasketches.apache.org
