leerho commented on code in PR #676: URL: https://github.com/apache/datasketches-java/pull/676#discussion_r2229262727
########## src/main/java/org/apache/datasketches/count/CountMinSketch.java: ########## @@ -22,8 +22,8 @@ import org.apache.datasketches.common.Family; import org.apache.datasketches.common.SketchesArgumentException; import org.apache.datasketches.common.SketchesException; +import org.apache.datasketches.common.Util; import org.apache.datasketches.hash.MurmurHash3; -import org.apache.datasketches.tuple.Util; Review Comment: This reference to /tuple.Util is only used for the computeSeedHash() in lines 364, 402 and 404. Because this method and the companion method checkSeedHashes() are used in other sketches and not just the Tuple Sketch, these two functions have been moved to /datasketches.common.Util. in the current main. All you need to do is change this import to .../datasketches.common.Util. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For additional commands, e-mail: dev-h...@datasketches.apache.org
