leerho commented on code in PR #675:
URL: https://github.com/apache/datasketches-java/pull/675#discussion_r2249321757
##########
src/main/java/org/apache/datasketches/hash/MurmurHash3.java:
##########
@@ -306,42 +308,34 @@ public static long[] hash(final byte[] key, final int
offsetBytes, final int len
//--Hash of ByteBuffer---------------------------------------------------
/**
- * Hash the remaining bytes of the given ByteBuffer starting at position().
+ * Hash the remaining bytes of the given ByteBuffer starting at position()
ending at limit (exclusive).
*
- * @param buf The input ByteBuffer. It must be non-null and non-empty.
+ * @param buf The input ByteBuffer. It must be non-null and non-empty and
using Little Endian.
Review Comment:
Hmm. Good point! Not just here, but everywhere BB is accepted as input, the
order should probably be checked. Although, to be consistent, checking for
native endianness is probably ok.
I wonder if there is a way to check endianness when the library (jar) is
loaded into memory. We could check and issue at least a warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org
For additional commands, e-mail: dev-h...@datasketches.apache.org
