freakyzoidberg commented on code in PR #682: URL: https://github.com/apache/datasketches-java/pull/682#discussion_r2255158271
########## src/main/java/org/apache/datasketches/quantiles/DirectUpdateDoublesSketch.java: ########## @@ -99,6 +100,11 @@ static DirectUpdateDoublesSketch newInstance(final int k, final MemorySegment ds return new DirectUpdateDoublesSketch(k, dstSeg, mSegReq); } + static HeapUpdateDoublesSketch heapify(final DirectUpdateDoublesSketch skIn) { + final MemorySegment segIn = skIn.getMemorySegment(); Review Comment: nit, we could avoid some debugging headaches here. ``` Objects.requireNonNull(skIN, "skIn must be non-null"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For additional commands, e-mail: dev-h...@datasketches.apache.org