freakyzoidberg commented on code in PR #46:
URL: https://github.com/apache/datasketches-go/pull/46#discussion_r2385340238
##########
frequencies/items_sketch.go:
##########
@@ -243,6 +244,23 @@ func (i *ItemsSketch[C]) GetUpperBound(item C) (int64,
error) {
return v + i.offset, err
}
+// frequencies return estimated frequency, lower bound frequency,
+// upper bound frequency at once.
+func (i *ItemsSketch[C]) frequencies(item C) (est, lower, upper int64, err
error) {
Review Comment:
Do you mind adding a test confirming equality with the public
GetEstimate/GetLowerBound/etc - as this logic is now effectively in two places.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
