leerho commented on code in PR #685: URL: https://github.com/apache/datasketches-java/pull/685#discussion_r2403142049
########## src/main/java/org/apache/datasketches/theta/UpdateSketch.java: ########## @@ -142,15 +157,23 @@ public static UpdateSketch heapify(final MemorySegment srcSeg, final long expect @Override public CompactSketch compact(final boolean dstOrdered, final MemorySegment dstWSeg) { - return componentsToCompact(getThetaLong(), getRetainedEntries(true), getSeedHash(), isEmpty(), - false, false, dstOrdered, dstWSeg, getCache()); + return componentsToCompact( + getThetaLong(), + getRetainedEntries(true), + getSeedHash(), + isEmpty(), + false, //is src compact + false, //is src ordered + dstOrdered, + dstWSeg, + getCache()); } @Override public int getCompactBytes() { final int preLongs = getCompactPreambleLongs(); final int dataLongs = getRetainedEntries(true); - return (preLongs + dataLongs) << 3; + return preLongs + dataLongs << 3; Review Comment: So I put the parenthesis back for sanity! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org For additional commands, e-mail: dev-h...@datasketches.apache.org