leerho commented on PR #690:
URL:
https://github.com/apache/datasketches-java/pull/690#issuecomment-3412854976
I have completed, I think, all the necessary name changes for /theta/ and
/tuple/ -- 124 files,
And /kll/ and /frequencies/ -- another 38 files.
I primarily focused on the public classes and methods where:
- There was an overlap of class names: This occured mostly between:
- /theta/ and /tuple/
- /kll/, /frequencies/, /quantiles/.
- By fixing the names in KLL and FI, I didn't have to change the names
in classic quantiles.
- It provided additional clarity.
- I did not attempt to rename the many public classes where the name was
already unique and it was not duplicated in any other family. I felt that
those were easy to understand what family they belonged to by their context.
Bear in mind that there are no code logic changes whatsoever. But of
course, the name changes constitute breaking changes on their own. All the unit
tests run just fine, even the CI tests.
Nonetheless, CoPilot complained about the fact that the deprecated methods
are still used in test, and still have a few transient references in /main/
that a are unavoidable — unless we remove all of the deprecated methods, which
I don’t have the energy or desire to do for this release.
CoPilot also complained about unused variables in the tests -- which I
mostly fixed - although I'm not too concerned about this in test code.
If I can get this quickly approved and merged by Oct 18th, I might -- but no
guarantees -- have the time to do a release before I leave on a long vacation.
Otherwise, it will have to wait until the 2nd week in November.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
