github-advanced-security[bot] commented on code in PR #691:
URL: https://github.com/apache/datasketches-java/pull/691#discussion_r2525415373
##########
src/test/java/org/apache/datasketches/quantiles/DoublesMiscTest.java:
##########
@@ -185,59 +185,59 @@
@Test
public void wrapEmptyCompactSketch() {
- final UpdateDoublesSketch s1 = DoublesSketch.builder().build();
+ final UpdatableQuantilesDoublesSketch s1 =
QuantilesDoublesSketch.builder().build();
final MemorySegment seg =
MemorySegment.ofArray(s1.compact().toByteArray());
- final DoublesSketch s2 = DoublesSketch.wrap(seg); // compact, so this is ok
+ final QuantilesDoublesSketch s2 = QuantilesDoublesSketch.wrap(seg); //
compact, so this is ok
Assert.assertTrue(s2.isEmpty());
}
@Test
public void heapifyUnionFromSparse() {
- final UpdateDoublesSketch s1 = DoublesSketch.builder().build();
+ final UpdatableQuantilesDoublesSketch s1 =
QuantilesDoublesSketch.builder().build();
s1.update(1);
s1.update(2);
final MemorySegment seg = MemorySegment.ofArray(s1.toByteArray(false));
- final DoublesUnion u = DoublesUnion.heapify(seg);
+ final QuantilesDoublesUnion u = QuantilesDoublesUnion.heapify(seg);
u.update(3);
- final DoublesSketch s2 = u.getResult();
+ final QuantilesDoublesSketch s2 = u.getResult();
Assert.assertEquals(s2.getMinItem(), 1.0);
Assert.assertEquals(s2.getMaxItem(), 3.0);
}
@Test
public void initializeUnionFromCompactSegment() {
- final UpdateDoublesSketch s1 = DoublesSketch.builder().build();
+ final UpdatableQuantilesDoublesSketch s1 =
QuantilesDoublesSketch.builder().build();
s1.update(1);
s1.update(2);
final MemorySegment seg = MemorySegment.ofArray(s1.toByteArray(true));
- final DoublesUnion u = DoublesUnion.heapify(seg);
+ final QuantilesDoublesUnion u = QuantilesDoublesUnion.heapify(seg);
u.update(3);
- final DoublesSketch s2 = u.getResult();
+ final QuantilesDoublesSketch s2 = u.getResult();
Assert.assertEquals(s2.getMinItem(), 1.0);
Assert.assertEquals(s2.getMaxItem(), 3.0);
}
@Test
public void unionFromUpdatableSegment() {
- final UpdateDoublesSketch s1 = DoublesSketch.builder().build();
+ final UpdatableQuantilesDoublesSketch s1 =
QuantilesDoublesSketch.builder().build();
s1.update(1);
s1.update(2);
final MemorySegment seg = MemorySegment.ofArray(s1.toByteArray(false));
- final DoublesUnion u = DoublesUnion.wrap(seg);
+ final QuantilesDoublesUnion u = QuantilesDoublesUnion.wrap(seg);
u.update(3);
- final DoublesSketch s2 = u.getResult();
+ final QuantilesDoublesSketch s2 = u.getResult();
Assert.assertEquals(s2.getMinItem(), 1.0);
Assert.assertEquals(s2.getMaxItem(), 3.0);
}
@Test
public void wrapUnionFromHeap() {
- final UpdateDoublesSketch s1 = DoublesSketch.builder().build();
+ final UpdatableQuantilesDoublesSketch s1 =
QuantilesDoublesSketch.builder().build();
s1.update(1);
s1.update(2);
final MemorySegment seg =
MemorySegment.ofArray(s1.toByteArray(false)).asReadOnly();
try {
- final DoublesUnion u = DoublesUnion.wrap(seg, null);
+ final QuantilesDoublesUnion u = QuantilesDoublesUnion.wrap(seg, null);
Review Comment:
## Unread local variable
Variable 'QuantilesDoublesUnion u' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
