github-advanced-security[bot] commented on code in PR #692:
URL: https://github.com/apache/datasketches-java/pull/692#discussion_r2532220445
##########
src/test/java/org/apache/datasketches/hll/DirectUnionTest.java:
##########
@@ -319,31 +319,31 @@
@Test
public void checkMisc() {
try {
- final Union u = newUnion(HllUtil.MIN_LOG_K - 1);
+ final HllUnion u = newUnion(HllUtil.MIN_LOG_K - 1);
Review Comment:
## Unread local variable
Variable 'HllUnion u' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/950)
##########
src/test/java/org/apache/datasketches/hll/DirectUnionTest.java:
##########
@@ -319,31 +319,31 @@
@Test
public void checkMisc() {
try {
- final Union u = newUnion(HllUtil.MIN_LOG_K - 1);
+ final HllUnion u = newUnion(HllUtil.MIN_LOG_K - 1);
fail();
} catch (final SketchesArgumentException e) {
//expected
}
try {
- final Union u = newUnion(HllUtil.MAX_LOG_K + 1);
+ final HllUnion u = newUnion(HllUtil.MAX_LOG_K + 1);
Review Comment:
## Unread local variable
Variable 'HllUnion u' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/951)
##########
src/test/java/org/apache/datasketches/hll/HllSketchTest.java:
##########
@@ -431,15 +431,15 @@
@SuppressWarnings("unused")
@Test
public void checkJavadocExample() {
- Union union; HllSketch sk, sk2;
+ HllUnion union; HllSketch sk, sk2;
Review Comment:
## Unread local variable
Variable 'HllUnion union' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/952)
##########
src/test/java/org/apache/datasketches/hll/UnionTest.java:
##########
@@ -321,31 +315,31 @@
@Test
public void checkMisc() {
try {
- final Union u = newUnion(HllUtil.MIN_LOG_K - 1);
+ final HllUnion u = newUnion(HllUtil.MIN_LOG_K - 1);
Review Comment:
## Unread local variable
Variable 'HllUnion u' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/954)
##########
src/test/java/org/apache/datasketches/hll/HllSketchTest.java:
##########
@@ -431,15 +431,15 @@
@SuppressWarnings("unused")
@Test
public void checkJavadocExample() {
- Union union; HllSketch sk, sk2;
+ HllUnion union; HllSketch sk, sk2;
Review Comment:
## Unread local variable
Variable 'HllSketch sk2' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/953)
##########
src/test/java/org/apache/datasketches/hll/UnionTest.java:
##########
@@ -321,31 +315,31 @@
@Test
public void checkMisc() {
try {
- final Union u = newUnion(HllUtil.MIN_LOG_K - 1);
+ final HllUnion u = newUnion(HllUtil.MIN_LOG_K - 1);
fail();
} catch (final SketchesArgumentException e) {
//expected
}
try {
- final Union u = newUnion(HllUtil.MAX_LOG_K + 1);
+ final HllUnion u = newUnion(HllUtil.MAX_LOG_K + 1);
Review Comment:
## Unread local variable
Variable 'HllUnion u' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/955)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
