proost commented on PR #70: URL: https://github.com/apache/datasketches-go/pull/70#issuecomment-3635187649
Suggestion: If breaking change is acceptable, Because we currently not release theta sketch officially, I'd like to change returning format error([like this](https://github.com/apache/datasketches-go/blob/main/theta/hashtable.go#L124)) to sentinel error. Chaning to sentinel error avoids heap allocation when hash exceeds theta. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
