freakyzoidberg commented on code in PR #1: URL: https://github.com/apache/datasketches-rust/pull/1#discussion_r2616369040
########## tests/serialization_test_data/cpp_generated_files/frequent_long_n0_cpp.sk: ########## Review Comment: CPP / Java and Go repo do have some test that generate and cross-test the synopsis from the other repos. It's vey much convention and quite manual - and as Lee hinted in the other thread we didn't really think about how to scale this with more language (very much M*N issue) you can find the Java HLL x-check [here](https://github.com/apache/datasketches-java/blob/main/src/test/java/org/apache/datasketches/hll/HllSketchCrossLanguageTest.java) and the cpp ones for [ser](https://github.com/apache/datasketches-cpp/blob/master/hll/test/hll_sketch_serialize_for_java.cpp)/[de](https://github.com/apache/datasketches-cpp/blob/master/hll/test/hll_sketch_deserialize_from_java_test.cpp) there Also worth noting that not all synopsis are guaranteed to have byte for byte equality (they'll behave the same and are fully serializable/deserializable between language - but not all provide guarantee of idempotency generaton when looking at raw bytes - tldr not all rng are seeded - they could I suppose though) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
