tisonkun commented on code in PR #13: URL: https://github.com/apache/datasketches-rust/pull/13#discussion_r2617736752
########## Cargo.toml: ########## @@ -18,7 +18,21 @@ [package] name = "datasketches" version = "0.1.0" + edition = "2024" +rust-version = "1.85.0" Review Comment: edition 2024 requires at least MSRV=1.85. I personally like moving MSRV eagerly because the old toolchain doesn't get maintained anyway. But other library authors would like to stay as low as possible to keep a wide user adoption range, which, in turn, blocks their dependencies from bumping MSRV. This is another topic we may discuss later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
