tisonkun commented on code in PR #13: URL: https://github.com/apache/datasketches-rust/pull/13#discussion_r2618836255
########## .github/workflows/ci.yml: ########## @@ -0,0 +1,122 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: CI +on: + pull_request: + branches: [ main ] + push: + branches: [ main ] + +# Concurrency strategy: +# github.workflow: distinguish this workflow from others +# github.event_name: distinguish `push` event from `pull_request` event +# github.event.number: set to the number of the pull request if `pull_request` event +# github.run_id: otherwise, it's a `push` event, only cancel if we rerun the workflow +# +# Reference: +# https://docs.github.com/en/actions/using-jobs/using-concurrency +# https://docs.github.com/en/actions/learn-github-actions/contexts#github-context +concurrency: + group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.number || github.run_id }} + cancel-in-progress: true +jobs: + check: + name: Check + runs-on: ubuntu-24.04 + steps: + - uses: actions/checkout@v6 + - name: Delete rust-toolchain.toml + run: rm rust-toolchain.toml + - name: Install toolchain + uses: dtolnay/rust-toolchain@nightly + with: + components: rustfmt,clippy + - uses: Swatinem/rust-cache@v2 + - uses: taiki-e/install-action@v2 + with: + tool: typos-cli,taplo-cli,hawkeye + - name: Check all + run: | + hawkeye check + taplo format --check + typos + cargo +nightly fmt --all -- --check + cargo +nightly clippy --all-targets --all-features -- -D warnings + + msrv: + name: Resolve MSRV + runs-on: ubuntu-24.04 + outputs: + rust-versions: ${{ steps.metadata.outputs.rust-versions }} + steps: + - uses: actions/checkout@v6 + - name: Delete rust-toolchain.toml + run: rm rust-toolchain.toml + - name: Install toolchain + uses: dtolnay/rust-toolchain@nightly + - id: metadata + run: | + msrv=$(cargo metadata --format-version 1 --no-deps | jq -r '.packages[] | select(.name == "datasketches") | .rust_version') + echo "MSRV: $msrv" + echo "rust-versions=[\"${msrv}\", \"stable\"]" >> "$GITHUB_OUTPUT" Review Comment: Use `yq` over `cargo metadata` since `cargo metadata` can hardly tell what is "our crate". (You must hardcode the crate name as above) ``` msrv=$(yq '.package.rust-version' Cargo.toml) ``` Directly read from Cargo.toml. The only ceveat is that if later we move to a workspace setup, it would be `msrv=$(yq '.workspace.package.rust-version' Cargo.toml)` like what I'm testing on https://github.com/fast/logforth/pull/203. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
