tisonkun commented on code in PR #19:
URL: https://github.com/apache/datasketches-rust/pull/19#discussion_r2618993289
##########
.asf.yaml:
##########
@@ -28,28 +32,19 @@ github:
squash: true
merge: false
rebase: false
-# protected_branches:
-# main:
-# required_status_checks:
- # strict means "Require branches to be up to date before merging."
-# strict: true
-
-# required_pull_request_reviews:
-# dismiss_stale_reviews: false
-# required_approving_review_count: 1
-
- # squash or rebase must be allowed in the repo for this setting to be
set to true.
-# required_linear_history: false
-
-# required_signatures: false
-
- # requires all conversations to be resolved before merging is possible
-# required_conversation_resolution: false
+ del_branch_on_merge: true
+ protected_branches:
+ main:
+ required_status_checks:
+ contexts:
+ - Required
+ required_pull_request_reviews:
+ required_approving_review_count: 1
Review Comment:
It would require a committer's pull request to have one more approving
review before merging. But it should be fine as long as we have several active
committers overseeing this repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
