notfilippo commented on PR #21: URL: https://github.com/apache/datasketches-rust/pull/21#issuecomment-3656421311
> We can exclude the snapshots from VCS, as well. My preference would be that after a `git clone` I am able to run `cargo test` on the full test suite (including serde) without running other scripts. If we a simple command in a .sh file which generates the snapshot (e.g. via docker, which seems great!) I would argue we should still check the generated files in the repo. CI can make sure to let us know when the files need to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
