leerho opened a new issue, #22: URL: https://github.com/apache/datasketches-rust/issues/22
### Align public sketch class names so that the sketch family name is part of the class/file name. With the recent release of DS-Java 9.0.0 on Java 25, we did a major overhaul of the sketch naming conventions because over time as the library grew, we had inadvertently created name collisions. I don't know how this works in Rust, but the fact that the "main 'HllSketch' struct and primary interface" is called "sketch.rs" caught my eye. See [Java Release Tag 9.0.0](https://github.com/apache/datasketches-java/releases/tag/9.0.0). I would suggest renaming the file to hll_sketch.rs or something similar (following Rust conventions) to avoid future name collisions in documentation and in code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
