tisonkun commented on code in PR #24: URL: https://github.com/apache/datasketches-rust/pull/24#discussion_r2622622813
########## src/hll/mod.rs: ########## @@ -69,8 +69,8 @@ mod list; mod serialization; mod sketch; -pub use estimator::NumStdDev; -pub use sketch::HllSketch; +pub use self::estimator::NumStdDev; +pub use self::sketch::HllSketch; Review Comment: I found it when a mod name sometimes conflicts with a dependency name. Using `self::sketch::HllSketch` always unambiguously refers to the proper symbol. > Do we have tools to enforce this style repo-wide? Not quite easy. One can define a custom clippy rule or work with ast-grep. But this rule depends on whether the (pub use) symbol is within this crate/module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
