tisonkun commented on PR #23: URL: https://github.com/apache/datasketches-rust/pull/23#issuecomment-3663119316
> > cc @notfilippo @freakyzoidberg > > cc @leerho based on [#2 (comment)](https://github.com/apache/datasketches-rust/issues/2#issuecomment-3657395474), I made this impl as a combination of C++ & Java version. Welcome to give it a review. I'll add serde support today or tomorrow. But I'm still not quite sure what CDF and PMF are. It's possible to convey C++'s impl as is but I wonder a real world use case to understand its definition and usage. > > Without the x-serde this is quite hard to confirm if the synopsis are compatible But that can be done later a the implem progress > > Note I am no mathematician - but my humble understanding > > ### PMF -> Probability Mass Function > It returns the approximate fraction of data points (mass) that fall into specific "bins" or intervals. You give it an array of split points and it returns an array of mass fraction that sum up to 1. > > it's a histogram generator of sort > > ### CDF -> Cumulative Distribution Function > It returns the approximate fraction of data points that are less than (or equal to) each split point. CDF ~= running running sum of the PMF Thanks for your explaination @freakyzoidberg! Generally got it now. This PR is now ready for merge. Some follow-up improvement are documented above. Currently, the functionality is aligned with C++/Java impls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
