cboumalh commented on issue #699: URL: https://github.com/apache/datasketches-java/issues/699#issuecomment-3672977744
Hi @leerho, apologies about the language! It should have been with Java I agree. Just want to point out that the Tuple and Theta sketches I created are not with the same three hashes :) One is a, b, c the other is a, b, e. I guess my questions are these: 1) Why do we initialize it to null instead of a empty string array 2) Would we want to consider having stringArr set to an empty string array by default to avoid the NullPointerException without having to update the array? 3) Would we want to consider modes of aggregation for the string arrays (concat, union, intersection, ...)? Thanks again for the response! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
