tisonkun commented on issue #701:
URL:
https://github.com/apache/datasketches-java/issues/701#issuecomment-3672998937
> Can we agree that the path for Rust is to compress before serializing,
which means follow the Java version for this behavior.
This is correct.
> If so, can we close?
The issue here is that C++ can serialize a TDigest sketch `with_buffer`. So
Java's deserialization (heapify) should not assume no buffer in the bytes,
which causes the incompatibility. I can submit a patch to demonstrate it and
fix it.
There are even prepared test data where we test only those that compress
before serializing, not the `tdigest_double_buf_n{scale}_cpp.sk` ones.
https://github.com/apache/datasketches-java/blob/37edd8c9898f8f073aaafad7097cb0949eb84c85/src/test/java/org/apache/datasketches/tdigest/TDigestCrossLanguageTest.java#L37-L79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
