notfilippo commented on code in PR #31: URL: https://github.com/apache/datasketches-rust/pull/31#discussion_r2634348484
########## src/lib.rs: ########## @@ -26,5 +26,9 @@ #![cfg_attr(docsrs, feature(doc_cfg))] #![deny(missing_docs)] +// See https://github.com/apache/datasketches-rust/issues/28 for more information. +#[cfg(target_endian = "big")] Review Comment: Let's merge this as-is, but I would argue this should be emitted only when a user decides to use a sketch which is incompatible with big-endianess. We can do this via feature flags, where we have one flag for each sketch (default enables all of them) and we error IF the target_endian is big and the flag for CPC / Theta is on (while also emitting a message suggesting to disable them) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
