tisonkun opened a new pull request, #33: URL: https://github.com/apache/datasketches-rust/pull/33
cc @notfilippo @Xuanwo I'm trying to bring some useful format rules used in most of my projects: keep comments and imports consistent. Especially, unformatted imports can be a major source of unexpected patch conflicts. However, most of the new rules require a nightly toolchain to enable, which means a pre-commit-like hook is needed for contributors to run the formatter - it's not quite straightforward. I'm considering introducing a xtask-style dev tool and perhaps moving the main `datasketches` crate to a member of a workspace. (then we can have something like `cargo x lint` to apply all the rules instead of letting contributors know what is configured in the CI workflow) The other reason for adopting a workspace layout is that I'm considering bringing a binary target that can generate snapshots by the Rust implementation so that other languages' implementations can use it to test cross-language compatibility from Rust to theirs. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
